Skip to content

Restore old behavior allowing to set custom appstore#18442

Merged
rullzer merged 1 commit intomasterfrom
bugfix/noid/broken_appstoreurl_config
Dec 22, 2019
Merged

Restore old behavior allowing to set custom appstore#18442
rullzer merged 1 commit intomasterfrom
bugfix/noid/broken_appstoreurl_config

Conversation

@georgehrke
Copy link
Member

@georgehrke georgehrke commented Dec 17, 2019

Signed-off-by: Georg Ehrke [email protected]

@georgehrke georgehrke added the 2. developing Work in progress label Dec 17, 2019
@georgehrke georgehrke added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Dec 17, 2019
ChristophWurst
ChristophWurst requested changes Dec 17, 2019
View reviewed changes
@georgehrke
Copy link
Member Author

georgehrke commented Dec 17, 2019

will squash in a sec

@georgehrke georgehrke force-pushed the bugfix/noid/broken_appstoreurl_config branch from b0771e5 to 9d4cee8 Compare December 17, 2019 14:43
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 17, 2019
@ChristophWurst ChristophWurst added this to the Nextcloud 18 milestone Dec 17, 2019
@ChristophWurst
Copy link
Member

ChristophWurst commented Dec 17, 2019

do you want to backport this?

@rullzer
Copy link
Member

rullzer commented Dec 17, 2019

CI is not happy

kesselb
kesselb reviewed Dec 17, 2019
View reviewed changes
kesselb
kesselb reviewed Dec 17, 2019
View reviewed changes
This was referenced Dec 19, 2019
Merged
Merged
@rullzer rullzer added 3. to review Waiting for reviews and removed 4. to release Ready to be released and/or waiting for tests to finish labels Dec 19, 2019
@rullzer
Copy link
Member

rullzer commented Dec 19, 2019

Did some fixups. Test should pass now

@rullzer rullzer force-pushed the bugfix/noid/broken_appstoreurl_config branch from 389bb41 to f0bef88 Compare December 22, 2019 14:06
@rullzer rullzer merged commit e5d7782 into master Dec 22, 2019
@rullzer rullzer deleted the bugfix/noid/broken_appstoreurl_config branch December 22, 2019 19:18
@georgehrke
Copy link
Member Author

georgehrke commented Jan 6, 2020

/backport to stable17

1 similar comment
@georgehrke
Copy link
Member Author

georgehrke commented Jan 6, 2020

/backport to stable17

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jan 6, 2020
Merged
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Jan 6, 2020

backport to stable17 in #18694

@juliusknorr
Copy link
Member

juliusknorr commented Jan 7, 2020

Requires #18546 as well

@nickvergessen
Copy link
Member

nickvergessen commented Jan 9, 2020

This breaks the "an you update to the next major" as it assumes now that fileName is also the file name on the api endpoint.
But future-apps.json and apps.json both need to request the apps.json endpoint. They just use different request parameters.

@georgehrke
Copy link
Member Author

georgehrke commented Jan 9, 2020

Fix is in #18786

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kesselb kesselb kesselb left review comments

@rullzer rullzer rullzer approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees

No one assigned

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

Nextcloud 18.0.0

Development

Successfully merging this pull request may close these issues.

6 participants

@georgehrke @ChristophWurst @rullzer @juliusknorr @nickvergessen @kesselb