Fix removing groups that have a slash in the name#18228
Merged
Conversation
skjnldsv
approved these changes
Dec 4, 2019
gary-kim
commented
Dec 4, 2019
Member
Author
There was a problem hiding this comment.
Should add some acceptance tests
EDIT: Oh, acceptance tests for this are currently disabled because of a needed patch?
server/tests/acceptance/features/users.feature
Lines 71 to 79 in 81b919e
@skjnldsv Do you think these could be reenabled now? Should probably be a different PR.
Member
Highly doubt it, we're late by one major on selenium. |
GretaD
approved these changes
Dec 4, 2019
Member
|
Needs a rebase |
Signed-off-by: Gary Kim <gary@garykim.dev>
a83e1f2 to
5ae3860
Compare
Member
Author
|
@rullzer Done |
This was referenced Dec 5, 2019
This was referenced Dec 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #18211
Fix removing groups that have a slash in the name such as
/test.I will backport manually once this is merged.