Conversation
georgehrke
commented
Nov 26, 2019
| \OC::$server->getConfig() | ||
| ); | ||
| $groupPrincipalBackend = new GroupPrincipalBackend($groupManager, $userSession, $shareManager, $l10n); | ||
| $groupPrincipalBackend = new GroupPrincipalBackend($groupManager, $userSession, $shareManager); |
Member
Author
There was a problem hiding this comment.
GroupPrincipalBackend doesn't even take a fourth parameter: (Also not on /stable(15|16|17)/)
https://github.com/nextcloud/server/blob/master/apps/dav/lib/DAV/GroupPrincipalBackend.php#L55
Not sure why it was there in the first place.
99b4447 to
9964030
Compare
Member
Author
|
/backport to stable17 |
Member
Author
|
/backport to stable16 |
tcitworld
approved these changes
Nov 29, 2019
Member
|
Rebase ;) |
…kend for Sabre/DAV Signed-off-by: Georg Ehrke <developer@georgehrke.com>
9964030 to
c3748cf
Compare
Member
Author
|
Rebased |
|
The backport to stable17 failed. Please do this backport manually. |
Member
Author
|
GRMPF |
|
The backport to stable16 failed. Please do this backport manually. |
Member
Author
|
Backport to stable17: #18205 |
Member
|
@georgehrke Do we still need a backport for 16 as well? |
Member
Author
|
ideally yes, let me look into it, so we can include it in the maintenance releases. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #11087