Conversation
Member
|
Great stuff! Only tiny things:
👍 |
Member
|
I’m also thinking to totally drop the "actions" term in favor of only saying "flow" everywhere.
This makes it much simpler and understandable. We don’t need to differentiate between "unfinished flows" and "flows". What do you think @karlitschek @jospoortvliet? |
Member
|
Also needs nextcloud/appstore#628 |
blizzz
approved these changes
Nov 26, 2019
Member
blizzz
left a comment
There was a problem hiding this comment.
for further polishing:
- when a second row of operations is shown, don't hide its elements (the + is visible after all anyway)
- on wide windows, show more than 3 operations per row
rullzer
approved these changes
Nov 26, 2019
Member
rullzer
left a comment
There was a problem hiding this comment.
Lets do this. And fix the rest in follow ups
Member
Author
|
Fixed wording issues and rebase. Leaving the rest for polishing later. |
ce0da3b to
5c07f4b
Compare
Member
|
tests do 💥 |
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
5c07f4b to
0b0c7b5
Compare
Member
Author
|
Should run fine now, let's see |
Member
|
Done! @juliushaertl can you make issues out of the open todos? |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another round of polishing for workflows as discussed at the contributor week:
ToDo for later polishing