Do not reset the list after adding cached entries#1771
Merged
LukasReschke merged 1 commit intomasterfrom Oct 18, 2016
Merged
Conversation
|
@nickvergessen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @MorrisJobke to be a potential reviewer. |
Member
Author
|
Let me write unit tests for this |
Signed-off-by: Joas Schilling <coding@schilljs.com>
1414c8d to
4d6ec43
Compare
Member
|
Tested and works 👍 |
Current coverage is 57.32% (diff: 100%)@@ master #1771 diff @@
==========================================
Files 1075 1075
Lines 61278 61291 +13
Methods 6864 6864
Messages 0 0
Branches 0 0
==========================================
+ Hits 35092 35134 +42
+ Misses 26186 26157 -29
Partials 0 0
|
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Steps
Expected
Rule 1:
Rule 2:
Actual
Rule 1:
Rule 2:
Found while looking into https://help.nextcloud.com/t/files-access-control-issue-with-browsing-folders/3608/3