hide storage wrapper warning for the readonly storage#1722
Merged
MorrisJobke merged 1 commit intomasterfrom Oct 18, 2016
Merged
hide storage wrapper warning for the readonly storage#1722MorrisJobke merged 1 commit intomasterfrom
MorrisJobke merged 1 commit intomasterfrom
Conversation
|
@MorrisJobke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nickvergessen, @icewind1991 and @PVince81 to be potential reviewers. |
Member
|
Signed-off 🙈 But LGTM otherwise |
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
e047e17 to
4d28358
Compare
Member
Author
Done |
Member
|
it gets the job done but... 🙈 🙊 LGTM |
Member
Author
|
@icewind1991 @karlitschek should we backport this? Currently there are thousands of those log lines here in our log 🙈 |
Member
|
Please backport! :) |
Member
|
Let's also add |
Member
Author
|
backported via #2186 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One part of #1652
cc @icewind1991 @nickvergessen