Merged
Conversation
* avoids useless FS operation * avoids useless DB writes * avoids useless addressbook updates * addendum to #17001 Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
kesselb
reviewed
Sep 4, 2019
| // use the checksum before modifications | ||
| $checksum = md5($this->image->data()); | ||
|
|
||
| if($checksum === $this->config->getUserValue($this->uid, 'user_ldap', 'lastAvatarChecksum', '')) { |
Contributor
There was a problem hiding this comment.
A const for lastAvatarChecksum would be nice 👍
kesselb
reviewed
Sep 4, 2019
Member
|
Master is no 18 development. If this needs to go into 17 please follow the normal backport procedures after merging. |
Member
Author
|
/backport to stable17 |
Member
Author
|
/backport to stable16 |
Member
Author
|
still looking for another reviewer :) |
|
backport to stable17 in #17372 |
|
backport to stable16 in #17373 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addendum to #17001 (see there for details)