Remove orphaned calendar data from deleted subscriptions#16835
Merged
Remove orphaned calendar data from deleted subscriptions#16835
Conversation
Member
Author
|
|
tcitworld
commented
Aug 22, 2019
5b1f59c to
456fb7e
Compare
nickvergessen
requested changes
Aug 22, 2019
a66b946 to
7624322
Compare
georgehrke
reviewed
Aug 26, 2019
Member
|
Otherwise this looks like a reasonable change to me 👍 |
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
7624322 to
e2b539b
Compare
nickvergessen
approved these changes
Aug 26, 2019
Member
|
/backport to stable16 |
Contributor
|
Thanks for addressing this (#16833) so quickly 👍 Could this also be backported to stable15? Caching webcal calendars was introduced in NC15. So it would definitely make sense to backport it also to NC15 |
georgehrke
approved these changes
Sep 4, 2019
|
backport to stable16 in #16994 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16833. Ref #13511