Allow to send the password of protected conversations#15394
Merged
nickvergessen merged 1 commit intomasterfrom May 7, 2019
Merged
Allow to send the password of protected conversations#15394nickvergessen merged 1 commit intomasterfrom
nickvergessen merged 1 commit intomasterfrom
Conversation
Member
Author
|
/backport to stable16 |
1 task
Member
Author
|
Regression from #14626 Before all http methods were redirected to the controller. Now it was only get, but we also need post. |
Signed-off-by: Joas Schilling <coding@schilljs.com>
d1681f6 to
6c29401
Compare
danxuliu
previously requested changes
May 6, 2019
Member
danxuliu
left a comment
There was a problem hiding this comment.
Maybe I did something wrong, but it does not work for me. Now not only the authentication ends in a blank page, but loading any /call/ URL ends in a blank page.
I guess that the router only admits one route with the same name, so the second route for POST overwrites the first route for GET.
That was the conflict you got on the review...
|
backport to stable16 in #15405 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rel nextcloud/spreed#1768