Don't show 'Personal' header in settings when Admin section is not there#14666
Don't show 'Personal' header in settings when Admin section is not there#14666MorrisJobke merged 2 commits intomasterfrom
Conversation
|
@jancborchardt Mind to rebase on current master, because there were quite some fixes merged lately. |
f8a604c to
a25f956
Compare
|
This breaks the acceptance tests that checks for the personal header :P |
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
a25f956 to
33bafb8
Compare
|
Rebased on master, but the test is not so easy to fix, as if we would change the:
it wouldn’t test for the entire section? So it should check for the content instead of the heading. (FYI I’m on vacation and it’s out of my abilities, so I’m happy for someone to take over. :) |
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
I adjusted and fixed them 👍 |
|
Let's get this into 16 as it is just a small fix |
|
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 17117: failureTESTS=carddavtester-old-endpoint
|
|
Completely unrelated failure. I haven't seen this before. |
For regular users we don’t need to show the "Personal" heading because there’s no other headings anyway. For admins nothing changes.
