Skip to content

Add hint to user documentation (Federation)#14586

Merged
MorrisJobke merged 2 commits intomasterfrom
hint-user-docs-federation
Mar 11, 2019
Merged

Add hint to user documentation (Federation)#14586
MorrisJobke merged 2 commits intomasterfrom
hint-user-docs-federation

Conversation

@MariusBluem
Copy link
Member

@MariusBluem MariusBluem commented Mar 7, 2019

Cough ... Sorry for spamming with PRs on Federation user settings :) This is the last one ...

Signed-off-by: Marius Blüm marius@lineone.io

@MariusBluem MariusBluem added this to the Nextcloud 16 milestone Mar 7, 2019
rullzer
rullzer approved these changes Mar 7, 2019
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

@MorrisJobke
Copy link
Member

MorrisJobke commented Mar 8, 2019

Looks a bit misplaced:
bildschirmfoto 2019-03-08 um 09 44 31

MorrisJobke
MorrisJobke approved these changes Mar 11, 2019
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the layout issue - works now 👍

MariusBluem and others added 2 commits March 11, 2019 12:47
@MariusBluem @MorrisJobke
Add hint to user documentation (Federation)
ab488a4 
Signed-off-by: Marius Blüm <marius@lineone.io>
@MorrisJobke
Fix display of i in personal settings
89ed84e 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke MorrisJobke force-pushed the hint-user-docs-federation branch from 9d7112b to 89ed84e Compare March 11, 2019 11:47
@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 11, 2019
@faily-bot
Copy link

faily-bot bot commented Mar 11, 2019

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 16909: failure

TESTS=integration-federation_features

  • build/integration/federation_features/federated.feature:183
  • build/integration/federation_features/federated.feature:232
  • build/integration/federation_features/federated.feature:247
  • build/integration/federation_features/federated.feature:263
Show full log 
[Mon Mar 11 11:58:47 2019] 127.0.0.1:53644 [200]: /ocs/v1.php/apps/testing/api/v1/app/files_sharing/incoming_server2server_group_share_enabled
[Mon Mar 11 11:58:47 2019] 127.0.0.1:53646 [200]: /ocs/v1.php/apps/testing/api/v1/app/files_sharing/outgoing_server2server_group_share_enabled
  Scenario: Reshare a federated shared file                                                             # /drone/src/github.com/nextcloud/server/build/integration/federation_features/federated.feature:183
    Given Using server "REMOTE"                                                                         # FederationContext::usingServer()
[Mon Mar 11 11:58:47 2019] 127.0.0.1:33778 [404]: /ocs/v2.php/cloud/users/user1
[Mon Mar 11 11:58:48 2019] 127.0.0.1:33780 [200]: /ocs/v1.php/cloud/users
[Mon Mar 11 11:58:48 2019] 127.0.0.1:33784 [200]: /ocs/v1.php/cloud/users/user1
[Mon Mar 11 11:58:48 2019] 127.0.0.1:33788 [200]: /ocs/v2.php/cloud/users/user1
    And user "user1" exists                                                                             # FederationContext::assureUserExists()
[Mon Mar 11 11:58:48 2019] 127.0.0.1:33790 [404]: /ocs/v2.php/cloud/users/user2
[Mon Mar 11 11:58:48 2019] 127.0.0.1:33796 [200]: /ocs/v1.php/cloud/users
[Mon Mar 11 11:58:49 2019] 127.0.0.1:33798 [200]: /ocs/v1.php/cloud/users/user2
[Mon Mar 11 11:58:49 2019] 127.0.0.1:33804 [200]: /ocs/v2.php/cloud/users/user2
    And user "user2" exists                                                                             # FederationContext::assureUserExists()
    And Using server "LOCAL"                                                                            # FederationContext::usingServer()
[Mon Mar 11 11:58:49 2019] 127.0.0.1:53678 [404]: /ocs/v2.php/cloud/users/user0
[Mon Mar 11 11:58:49 2019] 127.0.0.1:53682 [200]: /ocs/v1.php/cloud/users
[Mon Mar 11 11:58:49 2019] 127.0.0.1:53684 [200]: /ocs/v1.php/cloud/users/user0
[Mon Mar 11 11:58:49 2019] 127.0.0.1:53690 [200]: /ocs/v2.php/cloud/users/user0
    And user "user0" exists                                                                             # FederationContext::assureUserExists()
[Mon Mar 11 11:58:49 2019] 127.0.0.1:33824 [200]: /ocm-provider/
[Mon Mar 11 11:58:49 2019] 127.0.0.1:33828 [201]: /index.php/ocm/shares
[Mon Mar 11 11:58:49 2019] 127.0.0.1:53694 [200]: /ocs/v1.php/apps/files_sharing/api/v1/shares
    And User "user0" from server "LOCAL" shares "/textfile0.txt" with user "user1" from server "REMOTE" # FederationContext::federateSharing()
[Mon Mar 11 11:58:50 2019] 127.0.0.1:33830 [200]: /ocs/v1.php/apps/files_sharing/api/v1/remote_shares/pending
[Mon Mar 11 11:58:50 2019] 127.0.0.1:53706 [200]: //ocm-provider/
[Mon Mar 11 11:58:50 2019] 127.0.0.1:53708 [201]: /index.php/ocm/notifications
[Mon Mar 11 11:58:50 2019] 127.0.0.1:53710 [200]: //ocs-provider/
[Mon Mar 11 11:58:50 2019] 127.0.0.1:53714 [200]: /ocs/v2.php/cloud/shares/8/accept?format=json
[Mon Mar 11 11:58:50 2019] 127.0.0.1:33832 [200]: /ocs/v1.php/apps/files_sharing/api/v1/remote_shares/pending/9
    And User "user1" from server "REMOTE" accepts last pending share                                    # FederationContext::acceptLastPendingShare()
    And Using server "REMOTE"                                                                           # FederationContext::usingServer()
    And As an "user1"                                                                                   # FederationContext::asAn()
[Mon Mar 11 11:58:50 2019] 127.0.0.1:53722 [200]: //ocs-provider/
[Mon Mar 11 11:58:50 2019] 127.0.0.1:53724 [200]: //status.php
[Mon Mar 11 11:58:50 2019] 127.0.0.1:53726 [200]: //status.php
[Mon Mar 11 11:58:50 2019] 127.0.0.1:53728 [200]: /index.php/apps/files_sharing/shareinfo?t=L29OEJaQugitffS
[Mon Mar 11 11:58:50 2019] 127.0.0.1:33844 [200]: /ocs/v1.php/apps/files_sharing/api/v1/shares
    When creating a share with                                                                          # FederationContext::creatingShare()
      | path        | /textfile0 (2).txt |
      | shareType   | 0                  |
      | shareWith   | user2              |
      | permissions | 19                 |
    Then the OCS status code should be "100"                                                            # FederationContext::theOCSStatusCodeShouldBe()
      Failed asserting that SimpleXMLElement Object &000000007dccbc19000000002f5a2f9b (
          0 => '404'
      ) matches expected '100'.
    And the HTTP status code should be "200"                                                            # FederationContext::theHTTPStatusCodeShouldBe()
    And Share fields of last share match with                                                           # FederationContext::checkShareFields()
      | id                     | A_NUMBER           |
      | item_type              | file               |
      | item_source            | A_NUMBER           |
      | share_type             | 0                  |
      | file_source            | A_NUMBER           |
      | path                   | /textfile0 (2).txt |
      | permissions            | 19                 |
      | stime                  | A_NUMBER           |
      | storage                | A_NUMBER           |
      | mail_send              | 1                  |
      | uid_owner              | user1              |
      | file_parent            | A_NUMBER           |
      | displayname_owner      | user1              |
      | share_with             | user2              |
      | share_with_displayname | user2              |
[Mon Mar 11 11:58:50 2019] 127.0.0.1:53732 [200]: /ocs/v1.php/cloud/users/user0
[Mon Mar 11 11:58:50 2019] 127.0.0.1:53742 [404]: /ocs/v2.php/cloud/users/user0
[Mon Mar 11 11:58:51 2019] 127.0.0.1:53754 [200]: //ocm-provider/
[Mon Mar 11 11:58:51 2019] 127.0.0.1:53756 [400]: /index.php/ocm/notifications
[Mon Mar 11 11:58:51 2019] error while sending notification for federated share: Client error: `POST http://localhost:8080/index.php/ocm/notifications` resulted in a `400 Bad request` response:
{"message":"Can not find share with ID: 8"}

[Mon Mar 11 11:58:57 2019] 127.0.0.1:54066 [200]: /ocs/v1.php/apps/testing/api/v1/app/files_sharing/incoming_server2server_group_share_enabled
[Mon Mar 11 11:58:57 2019] 127.0.0.1:54072 [200]: /ocs/v1.php/apps/testing/api/v1/app/files_sharing/outgoing_server2server_group_share_enabled
  Scenario: Overwrite a federated shared folder as recipient                                             # /drone/src/github.com/nextcloud/server/build/integration/federation_features/federated.feature:232
    Given Using server "REMOTE"                                                                          # FederationContext::usingServer()
[Mon Mar 11 11:58:57 2019] 127.0.0.1:34208 [404]: /ocs/v2.php/cloud/users/user1
[Mon Mar 11 11:58:57 2019] 127.0.0.1:34214 [200]: /ocs/v1.php/cloud/users
[Mon Mar 11 11:58:58 2019] 127.0.0.1:34226 [200]: /ocs/v1.php/cloud/users/user1
[Mon Mar 11 11:58:58 2019] 127.0.0.1:34248 [200]: /ocs/v2.php/cloud/users/user1
    And user "user1" exists                                                                              # FederationContext::assureUserExists()
[Mon Mar 11 11:58:58 2019] 127.0.0.1:34252 [404]: /ocs/v2.php/cloud/users/user2
[Mon Mar 11 11:58:58 2019] 127.0.0.1:34256 [200]: /ocs/v1.php/cloud/users
[Mon Mar 11 11:58:59 2019] 127.0.0.1:34282 [200]: /ocs/v1.php/cloud/users/user2
[Mon Mar 11 11:58:59 2019] 127.0.0.1:34302 [200]: /ocs/v2.php/cloud/users/user2
    And user "user2" exists                                                                              # FederationContext::assureUserExists()
    And Using server "LOCAL"                                                                             # FederationContext::usingServer()
[Mon Mar 11 11:58:59 2019] 127.0.0.1:54182 [404]: /ocs/v2.php/cloud/users/user0
[Mon Mar 11 11:58:59 2019] 127.0.0.1:54186 [200]: /ocs/v1.php/cloud/users
[Mon Mar 11 11:59:00 2019] 127.0.0.1:54194 [200]: /ocs/v1.php/cloud/users/user0
[Mon Mar 11 11:59:00 2019] 127.0.0.1:54214 [200]: /ocs/v2.php/cloud/users/user0
    And user "user0" exists                                                                              # FederationContext::assureUserExists()
[Mon Mar 11 11:59:00 2019] 127.0.0.1:34358 [200]: /ocm-provider/
[Mon Mar 11 11:59:00 2019] 127.0.0.1:34360 [201]: /index.php/ocm/shares
[Mon Mar 11 11:59:00 2019] 127.0.0.1:54218 [200]: /ocs/v1.php/apps/files_sharing/api/v1/shares
    And User "user0" from server "LOCAL" shares "/PARENT" with user "user1" from server "REMOTE"         # FederationContext::federateSharing()
[Mon Mar 11 11:59:00 2019] 127.0.0.1:34364 [200]: /ocs/v1.php/apps/files_sharing/api/v1/remote_shares/pending
[Mon Mar 11 11:59:01 2019] 127.0.0.1:54246 [200]: //ocm-provider/
[Mon Mar 11 11:59:01 2019] 127.0.0.1:54248 [201]: /index.php/ocm/notifications
[Mon Mar 11 11:59:01 2019] 127.0.0.1:54250 [200]: //ocs-provider/
[Mon Mar 11 11:59:01 2019] 127.0.0.1:54254 [200]: /ocs/v2.php/cloud/shares/10/accept?format=json
[Mon Mar 11 11:59:01 2019] 127.0.0.1:34370 [200]: /ocs/v1.php/apps/files_sharing/api/v1/remote_shares/pending/11
    And User "user1" from server "REMOTE" accepts last pending share                                     # FederationContext::acceptLastPendingShare()
    And Using server "REMOTE"                                                                            # FederationContext::usingServer()
    And As an "user1"                                                                                    # FederationContext::asAn()
    And User "user1" modifies text of "/textfile0.txt" with text "BLABLABLA"                             # FederationContext::modifyTextOfFile()
[Mon Mar 11 11:59:01 2019] 127.0.0.1:54280 [200]: //ocs-provider/
[Mon Mar 11 11:59:01 2019] 127.0.0.1:54288 [401]: /public.php/webdav/textfile0.txt
[Mon Mar 11 11:59:01 2019] 127.0.0.1:54290 [404]: /public.php/webdav/textfile0.txt
[Mon Mar 11 11:59:01 2019] 127.0.0.1:54292 [200]: //status.php
[Mon Mar 11 11:59:01 2019] 127.0.0.1:54294 [200]: //status.php
[Mon Mar 11 11:59:01 2019] 127.0.0.1:54296 [200]: /index.php/apps/files_sharing/shareinfo?t=yUnxgAUJvAqTgWC
[Mon Mar 11 11:59:01 2019] Undefined index: size at /drone/src/github.com/nextcloud/server/lib/private/Files/View.php#1324
[Mon Mar 11 11:59:01 2019] Undefined index: storage_mtime at /drone/src/github.com/nextcloud/server/lib/private/Files/Cache/Watcher.php#126
[Mon Mar 11 11:59:01 2019] 127.0.0.1:54298 [207]: /public.php/webdav/
[Mon Mar 11 11:59:01 2019] Undefined index: etag at /drone/src/github.com/nextcloud/server/lib/private/Files/Storage/DAV.php#784
[Mon Mar 11 11:59:01 2019] 127.0.0.1:54304 [200]: //status.php
[Mon Mar 11 11:59:01 2019] 127.0.0.1:54306 [200]: //status.php
[Mon Mar 11 11:59:01 2019] 127.0.0.1:54308 [200]: /index.php/apps/files_sharing/shareinfo?t=yUnxgAUJvAqTgWC
[Mon Mar 11 11:59:01 2019] Undefined index: mimetype at /drone/src/github.com/nextcloud/server/lib/private/Files/Cache/Watcher.php#108
[Mon Mar 11 11:59:01 2019] 127.0.0.1:34402 [404]: /remote.php/webdav/PARENT%20(2)/textfile0.txt
    When User "user1" uploads file "../../data/user1/files/textfile0.txt" to "/PARENT (2)/textfile0.txt" # FederationContext::userUploadsAFileTo()
      Client error: `PUT http://localhost:8180/remote.php/webdav/PARENT%20(2)/textfile0.txt` resulted in a `404 Not Found` response:
      <?xml version="1.0" encoding="utf-8"?>
      <d:error xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns">
        <s:exception>Sabre\DA (truncated...)
       (GuzzleHttp\Exception\ClientException)
    And Downloading file "/PARENT (2)/textfile0.txt" with range "bytes=0-8"                              # FederationContext::downloadFileWithRange()
    Then Downloaded content should be "BLABLABLA"                                                        # FederationContext::downloadedContentShouldBe()
[Mon Mar 11 11:59:02 2019] 127.0.0.1:54310 [200]: /ocs/v1.php/cloud/users/user0
[Mon Mar 11 11:59:02 2019] 127.0.0.1:54336 [404]: /ocs/v2.php/cloud/users/user0
[Mon Mar 11 11:59:02 2019] 127.0.0.1:54366 [200]: //ocm-provider/
[Mon Mar 11 11:59:02 2019] 127.0.0.1:54368 [400]: /index.php/ocm/notifications
[Mon Mar 11 11:59:02 2019] error while sending notification for federated share: Client error: `POST http://localhost:8080/index.php/ocm/notifications` resulted in a `400 Bad request` response:
{"message":"Can not find share with ID: 10"}

[Mon Mar 11 11:59:03 2019] 127.0.0.1:54412 [200]: /ocs/v1.php/apps/testing/api/v1/app/files_sharing/incoming_server2server_group_share_enabled
[Mon Mar 11 11:59:03 2019] 127.0.0.1:54416 [200]: /ocs/v1.php/apps/testing/api/v1/app/files_sharing/outgoing_server2server_group_share_enabled
  Scenario: Overwrite a federated shared file as recipient using old chunking                           # /drone/src/github.com/nextcloud/server/build/integration/federation_features/federated.feature:247
    Given Using server "REMOTE"                                                                         # FederationContext::usingServer()
[Mon Mar 11 11:59:03 2019] 127.0.0.1:34548 [404]: /ocs/v2.php/cloud/users/user1
[Mon Mar 11 11:59:04 2019] 127.0.0.1:34554 [200]: /ocs/v1.php/cloud/users
[Mon Mar 11 11:59:04 2019] 127.0.0.1:34560 [200]: /ocs/v1.php/cloud/users/user1
[Mon Mar 11 11:59:04 2019] 127.0.0.1:34578 [200]: /ocs/v2.php/cloud/users/user1
    And user "user1" exists                                                                             # FederationContext::assureUserExists()
[Mon Mar 11 11:59:04 2019] 127.0.0.1:34584 [404]: /ocs/v2.php/cloud/users/user2
[Mon Mar 11 11:59:04 2019] 127.0.0.1:34594 [200]: /ocs/v1.php/cloud/users
[Mon Mar 11 11:59:05 2019] 127.0.0.1:34608 [200]: /ocs/v1.php/cloud/users/user2
[Mon Mar 11 11:59:05 2019] 127.0.0.1:34638 [200]: /ocs/v2.php/cloud/users/user2
    And user "user2" exists                                                                             # FederationContext::assureUserExists()
    And Using server "LOCAL"                                                                            # FederationContext::usingServer()
[Mon Mar 11 11:59:05 2019] 127.0.0.1:54516 [404]: /ocs/v2.php/cloud/users/user0
[Mon Mar 11 11:59:05 2019] 127.0.0.1:54520 [200]: /ocs/v1.php/cloud/users
[Mon Mar 11 11:59:05 2019] 127.0.0.1:54536 [200]: /ocs/v1.php/cloud/users/user0
[Mon Mar 11 11:59:05 2019] 127.0.0.1:54568 [200]: /ocs/v2.php/cloud/users/user0
    And user "user0" exists                                                                             # FederationContext::assureUserExists()
[Mon Mar 11 11:59:05 2019] 127.0.0.1:34708 [200]: /ocm-provider/
[Mon Mar 11 11:59:05 2019] 127.0.0.1:34710 [201]: /index.php/ocm/shares
[Mon Mar 11 11:59:05 2019] 127.0.0.1:54574 [200]: /ocs/v1.php/apps/files_sharing/api/v1/shares
    And User "user0" from server "LOCAL" shares "/textfile0.txt" with user "user1" from server "REMOTE" # FederationContext::federateSharing()
[Mon Mar 11 11:59:06 2019] 127.0.0.1:34712 [200]: /ocs/v1.php/apps/files_sharing/api/v1/remote_shares/pending
[Mon Mar 11 11:59:06 2019] 127.0.0.1:54600 [200]: //ocm-provider/
[Mon Mar 11 11:59:06 2019] 127.0.0.1:54602 [201]: /index.php/ocm/notifications
[Mon Mar 11 11:59:06 2019] 127.0.0.1:54606 [200]: //ocs-provider/
[Mon Mar 11 11:59:06 2019] 127.0.0.1:54608 [200]: /ocs/v2.php/cloud/shares/11/accept?format=json
[Mon Mar 11 11:59:06 2019] 127.0.0.1:34718 [200]: /ocs/v1.php/apps/files_sharing/api/v1/remote_shares/pending/12
    And User "user1" from server "REMOTE" accepts last pending share                                    # FederationContext::acceptLastPendingShare()
    And Using server "REMOTE"                                                                           # FederationContext::usingServer()
    And As an "user1"                                                                                   # FederationContext::asAn()
[Mon Mar 11 11:59:06 2019] 127.0.0.1:54622 [200]: //ocs-provider/
[Mon Mar 11 11:59:06 2019] 127.0.0.1:54626 [401]: /public.php/webdav/
[Mon Mar 11 11:59:06 2019] 127.0.0.1:54628 [207]: /public.php/webdav/
[Mon Mar 11 11:59:06 2019] 127.0.0.1:54632 [200]: //status.php
[Mon Mar 11 11:59:06 2019] 127.0.0.1:54634 [200]: //status.php
[Mon Mar 11 11:59:06 2019] 127.0.0.1:54636 [200]: /index.php/apps/files_sharing/shareinfo?t=OkXvp1AIki6tzM6
[Mon Mar 11 11:59:06 2019] 127.0.0.1:34742 [404]: /remote.php/webdav/textfile0%20(2).txt-chunking-42-3-0
    And user "user1" uploads chunk file "1" of "3" with "AAAAA" to "/textfile0 (2).txt"                 # FederationContext::userUploadsChunkFileOfWithToWithChecksum()
      Client error: `PUT http://localhost:8180/remote.php/webdav/textfile0%20(2).txt-chunking-42-3-0` resulted in a `404 Not Found` response:
      <?xml version="1.0" encoding="utf-8"?>
      <d:error xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns">
        <s:exception>Sabre\DA (truncated...)
       (GuzzleHttp\Exception\ClientException)
    And user "user1" uploads chunk file "2" of "3" with "BBBBB" to "/textfile0 (2).txt"                 # FederationContext::userUploadsChunkFileOfWithToWithChecksum()
    And user "user1" uploads chunk file "3" of "3" with "CCCCC" to "/textfile0 (2).txt"                 # FederationContext::userUploadsChunkFileOfWithToWithChecksum()
    When Downloading file "/textfile0 (2).txt" with range "bytes=0-4"                                   # FederationContext::downloadFileWithRange()
    Then Downloaded content should be "AAAAA"                                                           # FederationContext::downloadedContentShouldBe()
[Mon Mar 11 11:59:06 2019] 127.0.0.1:54640 [200]: /ocs/v1.php/cloud/users/user0
[Mon Mar 11 11:59:07 2019] 127.0.0.1:54684 [404]: /ocs/v2.php/cloud/users/user0
[Mon Mar 11 11:59:07 2019] 127.0.0.1:54726 [200]: //ocm-provider/
[Mon Mar 11 11:59:07 2019] 127.0.0.1:54728 [400]: /index.php/ocm/notifications
[Mon Mar 11 11:59:07 2019] error while sending notification for federated share: Client error: `POST http://localhost:8080/index.php/ocm/notifications` resulted in a `400 Bad request` response:
{"message":"Can not find share with ID: 11"}

[Mon Mar 11 11:59:08 2019] 127.0.0.1:54792 [200]: /ocs/v1.php/apps/testing/api/v1/app/files_sharing/incoming_server2server_group_share_enabled
[Mon Mar 11 11:59:08 2019] 127.0.0.1:54804 [200]: /ocs/v1.php/apps/testing/api/v1/app/files_sharing/outgoing_server2server_group_share_enabled
  Scenario: Overwrite a federated shared folder as recipient using old chunking                  # /drone/src/github.com/nextcloud/server/build/integration/federation_features/federated.feature:263
    Given Using server "REMOTE"                                                                  # FederationContext::usingServer()
[Mon Mar 11 11:59:08 2019] 127.0.0.1:34940 [404]: /ocs/v2.php/cloud/users/user1
[Mon Mar 11 11:59:08 2019] 127.0.0.1:34948 [200]: /ocs/v1.php/cloud/users
[Mon Mar 11 11:59:09 2019] 127.0.0.1:34968 [200]: /ocs/v1.php/cloud/users/user1
[Mon Mar 11 11:59:09 2019] 127.0.0.1:34996 [200]: /ocs/v2.php/cloud/users/user1
    And user "user1" exists                                                                      # FederationContext::assureUserExists()
[Mon Mar 11 11:59:09 2019] 127.0.0.1:35010 [404]: /ocs/v2.php/cloud/users/user2
[Mon Mar 11 11:59:09 2019] 127.0.0.1:35020 [200]: /ocs/v1.php/cloud/users
[Mon Mar 11 11:59:09 2019] 127.0.0.1:35034 [200]: /ocs/v1.php/cloud/users/user2
[Mon Mar 11 11:59:09 2019] 127.0.0.1:35048 [200]: /ocs/v2.php/cloud/users/user2
    And user "user2" exists                                                                      # FederationContext::assureUserExists()
    And Using server "LOCAL"                                                                     # FederationContext::usingServer()
[Mon Mar 11 11:59:10 2019] 127.0.0.1:54924 [404]: /ocs/v2.php/cloud/users/user0
[Mon Mar 11 11:59:10 2019] 127.0.0.1:54930 [200]: /ocs/v1.php/cloud/users
[Mon Mar 11 11:59:10 2019] 127.0.0.1:54942 [200]: /ocs/v1.php/cloud/users/user0
[Mon Mar 11 11:59:10 2019] 127.0.0.1:54960 [200]: /ocs/v2.php/cloud/users/user0
    And user "user0" exists                                                                      # FederationContext::assureUserExists()
[Mon Mar 11 11:59:10 2019] 127.0.0.1:35096 [200]: /ocm-provider/
[Mon Mar 11 11:59:10 2019] 127.0.0.1:35098 [201]: /index.php/ocm/shares
[Mon Mar 11 11:59:10 2019] 127.0.0.1:54964 [200]: /ocs/v1.php/apps/files_sharing/api/v1/shares
    And User "user0" from server "LOCAL" shares "/PARENT" with user "user1" from server "REMOTE" # FederationContext::federateSharing()
[Mon Mar 11 11:59:10 2019] 127.0.0.1:35100 [200]: /ocs/v1.php/apps/files_sharing/api/v1/remote_shares/pending
[Mon Mar 11 11:59:10 2019] 127.0.0.1:54982 [200]: //ocm-provider/
[Mon Mar 11 11:59:10 2019] 127.0.0.1:54986 [201]: /index.php/ocm/notifications
[Mon Mar 11 11:59:10 2019] 127.0.0.1:54990 [200]: //ocs-provider/
[Mon Mar 11 11:59:11 2019] 127.0.0.1:54992 [200]: /ocs/v2.php/cloud/shares/12/accept?format=json
[Mon Mar 11 11:59:11 2019] 127.0.0.1:35106 [200]: /ocs/v1.php/apps/files_sharing/api/v1/remote_shares/pending/13
    And User "user1" from server "REMOTE" accepts last pending share                             # FederationContext::acceptLastPendingShare()
    And Using server "REMOTE"                                                                    # FederationContext::usingServer()
    And As an "user1"                                                                            # FederationContext::asAn()
[Mon Mar 11 11:59:11 2019] 127.0.0.1:55002 [200]: //ocs-provider/
[Mon Mar 11 11:59:11 2019] 127.0.0.1:55004 [200]: //status.php
[Mon Mar 11 11:59:11 2019] 127.0.0.1:55006 [200]: //status.php
[Mon Mar 11 11:59:11 2019] 127.0.0.1:55008 [200]: /index.php/apps/files_sharing/shareinfo?t=lHeL9e4ItqyYYeF
[Mon Mar 11 11:59:11 2019] Undefined index: size at /drone/src/github.com/nextcloud/server/lib/private/Files/View.php#1324
[Mon Mar 11 11:59:11 2019] Undefined index: storage_mtime at /drone/src/github.com/nextcloud/server/lib/private/Files/Cache/Watcher.php#126
[Mon Mar 11 11:59:11 2019] 127.0.0.1:55012 [401]: /public.php/webdav/
[Mon Mar 11 11:59:11 2019] 127.0.0.1:55014 [207]: /public.php/webdav/
[Mon Mar 11 11:59:11 2019] Undefined index: etag at /drone/src/github.com/nextcloud/server/lib/private/Files/Storage/DAV.php#784
[Mon Mar 11 11:59:11 2019] 127.0.0.1:55016 [200]: //status.php
[Mon Mar 11 11:59:11 2019] 127.0.0.1:55018 [200]: //status.php
[Mon Mar 11 11:59:11 2019] 127.0.0.1:55022 [200]: /index.php/apps/files_sharing/shareinfo?t=lHeL9e4ItqyYYeF
[Mon Mar 11 11:59:11 2019] Undefined index: mimetype at /drone/src/github.com/nextcloud/server/lib/private/Files/Cache/Watcher.php#108
[Mon Mar 11 11:59:11 2019] 127.0.0.1:35122 [404]: /remote.php/webdav/PARENT%20(2)/textfile0.txt-chunking-42-3-0
    And user "user1" uploads chunk file "1" of "3" with "AAAAA" to "/PARENT (2)/textfile0.txt"   # FederationContext::userUploadsChunkFileOfWithToWithChecksum()
      Client error: `PUT http://localhost:8180/remote.php/webdav/PARENT%20(2)/textfile0.txt-chunking-42-3-0` resulted in a `404 Not Found` response:
      <?xml version="1.0" encoding="utf-8"?>
      <d:error xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns">
        <s:exception>Sabre\DA (truncated...)
       (GuzzleHttp\Exception\ClientException)
    And user "user1" uploads chunk file "2" of "3" with "BBBBB" to "/PARENT (2)/textfile0.txt"   # FederationContext::userUploadsChunkFileOfWithToWithChecksum()
    And user "user1" uploads chunk file "3" of "3" with "CCCCC" to "/PARENT (2)/textfile0.txt"   # FederationContext::userUploadsChunkFileOfWithToWithChecksum()
    When Downloading file "/PARENT (2)/textfile0.txt" with range "bytes=3-13"                    # FederationContext::downloadFileWithRange()
    Then Downloaded content should be "AABBBBBCCCC"                                              # FederationContext::downloadedContentShouldBe()
[Mon Mar 11 11:59:11 2019] 127.0.0.1:55024 [200]: /ocs/v1.php/cloud/users/user0
[Mon Mar 11 11:59:11 2019] 127.0.0.1:55040 [404]: /ocs/v2.php/cloud/users/user0
[Mon Mar 11 11:59:12 2019] 127.0.0.1:55068 [200]: //ocm-provider/
[Mon Mar 11 11:59:12 2019] 127.0.0.1:55070 [400]: /index.php/ocm/notifications
[Mon Mar 11 11:59:12 2019] error while sending notification for federated share: Client error: `POST http://localhost:8080/index.php/ocm/notifications` resulted in a `400 Bad request` response:
{"message":"Can not find share with ID: 12"}

TESTS=integration-sharing-v1

  • build/integration/features/sharing-v1.feature:58
Show full log 
  Scenario: Creating a new public share                    # /drone/src/github.com/nextcloud/server/build/integration/features/sharing-v1.feature:58
[Mon Mar 11 11:59:40 2019] 127.0.0.1:56968 [404]: /ocs/v2.php/cloud/users/user0
[Mon Mar 11 11:59:40 2019] 127.0.0.1:56972 [200]: /ocs/v1.php/cloud/users
[Mon Mar 11 11:59:40 2019] 127.0.0.1:56982 [200]: /ocs/v1.php/cloud/users/user0
[Mon Mar 11 11:59:40 2019] 127.0.0.1:56990 [200]: /ocs/v2.php/cloud/users/user0
    Given user "user0" exists                              # FeatureContext::assureUserExists()
    And As an "user0"                                      # FeatureContext::asAn()
[Mon Mar 11 11:59:40 2019] 127.0.0.1:56994 [200]: /ocs/v1.php/apps/files_sharing/api/v1/shares
    When creating a share with                             # FeatureContext::creatingShare()
      | path      | welcome.txt |
      | shareType | 3           |
    Then the OCS status code should be "100"               # FeatureContext::theOCSStatusCodeShouldBe()
    And the HTTP status code should be "200"               # FeatureContext::theHTTPStatusCodeShouldBe()
[Mon Mar 11 11:59:41 2019] 127.0.0.1:57000 [404]: /index.php/s/bkRqQ3w9ZzYbTqq/download
    And Public shared file "welcome.txt" can be downloaded # FeatureContext::checkPublicSharedFile()
      Client error: `GET http://localhost:8080/index.php/s/bkRqQ3w9ZzYbTqq/download` resulted in a `404 Not Found` response (GuzzleHttp\Exception\ClientException)
[Mon Mar 11 11:59:41 2019] 127.0.0.1:57036 [200]: /ocs/v1.php/cloud/users/user0
[Mon Mar 11 11:59:41 2019] 127.0.0.1:57056 [404]: /ocs/v2.php/cloud/users/user0
[Mon Mar 11 11:59:41 2019] Login failed: 'user0' (Remote IP: '127.0.0.1')
[Mon Mar 11 11:59:41 2019] 127.0.0.1:57062 [401]: /remote.php/webdav/myFileToComment.txt
[Mon Mar 11 11:59:42 2019] 127.0.0.1:57064 [207]: /remote.php/dav/systemtags/
[Mon Mar 11 11:59:42 2019] Login failed: 'user0' (Remote IP: '127.0.0.1')
[Mon Mar 11 11:59:42 2019] 127.0.0.1:57068 [401]: /remote.php/webdav/myFileToTag.txt
[Mon Mar 11 11:59:42 2019] 127.0.0.1:57070 [404]: /remote.php/dav/addressbooks/users/admin/MyAddressbook
[Mon Mar 11 11:59:42 2019] 127.0.0.1:57076 [404]: /remote.php/dav/calendars/admin/MyCalendar

TESTS=acceptance, TESTS-ACCEPTANCE=app-files-sharing-link

  • tests/acceptance/features/app-files-sharing-link.feature:3
  • tests/acceptance/features/app-files-sharing-link.feature:26
  • tests/acceptance/features/app-files-sharing-link.feature:40
  • tests/acceptance/features/app-files-sharing-link.feature:60
  • tests/acceptance/features/app-files-sharing-link.feature:81
  • tests/acceptance/features/app-files-sharing-link.feature:116
  • tests/acceptance/features/app-files-sharing-link.feature:128
  • tests/acceptance/features/app-files-sharing-link.feature:139
Show full log 
  Scenario: open the menu in a public shared link                   # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-files-sharing-link.feature:3
    Given I act as John                                             # ActorContext::iActAs()
    And I am logged in                                              # LoginPageContext::iAmLoggedIn()
    And I share the link for "welcome.txt"                          # FilesAppSharingContext::iShareTheLinkFor()
    And I write down the shared link                                # FilesAppSharingContext::iWriteDownTheSharedLink()
    When I act as Jane                                              # ActorContext::iActAs()
    And I visit the shared link I wrote down                        # PublicShareContext::iVisitTheSharedLinkIWroteDown()
    And I see that the current page is the shared link I wrote down # PublicShareContext::iSeeThatTheCurrentPageIsTheSharedLinkIWroteDown()
    And I open the Share menu                                       # PublicShareContext::iOpenTheShareMenu()
      Share menu button in Shared file page could not be found after 100 seconds (NoSuchElementException)
    Then I see that the Share menu is shown                         # PublicShareContext::iSeeThatTheShareMenuIsShown()

  Scenario: show download again in a public shared link             # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-files-sharing-link.feature:26
    Given I act as John                                             # ActorContext::iActAs()
    And I am logged in                                              # LoginPageContext::iAmLoggedIn()
    And I share the link for "welcome.txt"                          # FilesAppSharingContext::iShareTheLinkFor()
    And I set the download of the shared link as hidden             # FilesAppSharingContext::iSetTheDownloadOfTheSharedLinkAsHidden()
    And I set the download of the shared link as shown              # FilesAppSharingContext::iSetTheDownloadOfTheSharedLinkAsShown()
    And I write down the shared link                                # FilesAppSharingContext::iWriteDownTheSharedLink()
    When I act as Jane                                              # ActorContext::iActAs()
    And I visit the shared link I wrote down                        # PublicShareContext::iVisitTheSharedLinkIWroteDown()
    And I see that the current page is the shared link I wrote down # PublicShareContext::iSeeThatTheCurrentPageIsTheSharedLinkIWroteDown()
    Then I see that the download button is shown                    # PublicShareContext::iSeeThatTheDownloadButtonIsShown()
      The download button is not visible yet after 100 seconds
    And I open the Share menu                                       # PublicShareContext::iOpenTheShareMenu()
    And I see that the Share menu is shown                          # PublicShareContext::iSeeThatTheShareMenuIsShown()

  Scenario: creation is not possible by default in a public shared folder # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-files-sharing-link.feature:40
    Given I act as John                                                   # ActorContext::iActAs()
    And I am logged in                                                    # LoginPageContext::iAmLoggedIn()
    And I create a new folder named "Shared folder"                       # FileListContext::iCreateANewFolderNamed()
    And I close the details view                                          # FilesAppContext::iCloseTheDetailsView()
    And I see that the details view is closed                             # FilesAppContext::iSeeThatTheDetailsViewIsClosed()
    And I share the link for "Shared folder"                              # FilesAppSharingContext::iShareTheLinkFor()
    And I write down the shared link                                      # FilesAppSharingContext::iWriteDownTheSharedLink()
    When I act as Jane                                                    # ActorContext::iActAs()
    And I visit the shared link I wrote down                              # PublicShareContext::iVisitTheSharedLinkIWroteDown()
    And I see that the current page is the shared link I wrote down       # PublicShareContext::iSeeThatTheCurrentPageIsTheSharedLinkIWroteDown()
    And I see that the file list is eventually loaded                     # FileListContext::iSeeThatTheFileListIsEventuallyLoaded()
    Then I see that it is not possible to create new files                # FileListContext::iSeeThatItIsNotPossibleToCreateNewFiles()
      Create menu button in file list could not be found (NoSuchElementException)

  Scenario: create folder in a public editable shared folder        # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-files-sharing-link.feature:60
    Given I act as John                                             # ActorContext::iActAs()
    And I am logged in                                              # LoginPageContext::iAmLoggedIn()
    And I create a new folder named "Editable shared folder"        # FileListContext::iCreateANewFolderNamed()
    And I close the details view                                    # FilesAppContext::iCloseTheDetailsView()
    And I see that the details view is closed                       # FilesAppContext::iSeeThatTheDetailsViewIsClosed()
    And I share the link for "Editable shared folder"               # FilesAppSharingContext::iShareTheLinkFor()
    And I set the shared link as editable                           # FilesAppSharingContext::iSetTheSharedLinkAsEditable()
    And I write down the shared link                                # FilesAppSharingContext::iWriteDownTheSharedLink()
      │ Copy link button in the details view in Files app could not be clicked
      │ Exception message: Element is no longer attached to the DOM
      │ For documentation on this error, please visit: http://seleniumhq.org/exceptions/stale_element_reference.html
      │ Build info: version: '2.53.1', revision: 'a36b8b1', time: '2016-06-30 17:37:03'
      │ System info: host: '2339ba1aeb2c', ip: '172.17.0.16', os.name: 'Linux', os.arch: 'amd64', os.version: '4.15.0-43-generic', java.version: '1.8.0_91'
      │ Driver info: driver.version: unknown
      │ Trying again
      │ 
    When I act as Jane                                              # ActorContext::iActAs()
    And I visit the shared link I wrote down                        # PublicShareContext::iVisitTheSharedLinkIWroteDown()
    And I see that the current page is the shared link I wrote down # PublicShareContext::iSeeThatTheCurrentPageIsTheSharedLinkIWroteDown()
    And I create a new folder named "Subfolder"                     # FileListContext::iCreateANewFolderNamed()
      Create menu button in file list could not be found after 100 seconds (NoSuchElementException)
    Then I see that the file list contains a file named "Subfolder" # FileListContext::iSeeThatTheFileListContainsAFileNamed()

  Scenario: owner sees folder created in the public page of an editable shared folder # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-files-sharing-link.feature:81
    Given I act as John                                                               # ActorContext::iActAs()
    And I am logged in                                                                # LoginPageContext::iAmLoggedIn()
    And I create a new folder named "Editable shared folder"                          # FileListContext::iCreateANewFolderNamed()
    And I close the details view                                                      # FilesAppContext::iCloseTheDetailsView()
    And I see that the details view is closed                                         # FilesAppContext::iSeeThatTheDetailsViewIsClosed()
    And I share the link for "Editable shared folder"                                 # FilesAppSharingContext::iShareTheLinkFor()
    And I set the shared link as editable                                             # FilesAppSharingContext::iSetTheSharedLinkAsEditable()
    And I write down the shared link                                                  # FilesAppSharingContext::iWriteDownTheSharedLink()
    And I act as Jane                                                                 # ActorContext::iActAs()
    And I visit the shared link I wrote down                                          # PublicShareContext::iVisitTheSharedLinkIWroteDown()
    And I see that the current page is the shared link I wrote down                   # PublicShareContext::iSeeThatTheCurrentPageIsTheSharedLinkIWroteDown()
    And I create a new folder named "Subfolder"                                       # FileListContext::iCreateANewFolderNamed()
      Create menu button in file list could not be found after 100 seconds (NoSuchElementException)
    And I see that the file list contains a file named "Subfolder"                    # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    When I act as John                                                                # ActorContext::iActAs()
    And I enter in the folder named "Editable shared folder"                          # FileListContext::iEnterInTheFolderNamed()
    Then I see that the file list contains a file named "Subfolder"                   # FileListContext::iSeeThatTheFileListContainsAFileNamed()

  Scenario: access a shared link protected by password with a valid password                   # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-files-sharing-link.feature:116
    Given I act as John                                                                        # ActorContext::iActAs()
    And I am logged in                                                                         # LoginPageContext::iAmLoggedIn()
    And I share the link for "welcome.txt" protected by the password "abcdef"                  # FilesAppSharingContext::iShareTheLinkForProtectedByThePassword()
    And I write down the shared link                                                           # FilesAppSharingContext::iWriteDownTheSharedLink()
    When I act as Jane                                                                         # ActorContext::iActAs()
    And I visit the shared link I wrote down                                                   # PublicShareContext::iVisitTheSharedLinkIWroteDown()
    And I see that the current page is the Authenticate page for the shared link I wrote down  # PublicShareContext::iSeeThatTheCurrentPageIsTheAuthenticatePageForTheSharedLinkIWroteDown()
      Failed asserting that two strings are equal.
      --- Expected
      +++ Actual
      @@ @@
      -'http://acceptance-app-files-sharing-link/index.php/s/8Xd83QaA6DWPDGB/authenticate/showShare'
      +'http://acceptance-app-files-sharing-link/index.php/s/8Xd83QaA6DWPDGB'
    And I authenticate with password "abcdef"                                                  # PublicShareContext::iAuthenticateWithPassword()
    Then I see that the current page is the shared link I wrote down                           # PublicShareContext::iSeeThatTheCurrentPageIsTheSharedLinkIWroteDown()
    And I see that the shared file preview shows the text "Welcome to your Nextcloud account!" # PublicShareContext::iSeeThatTheSharedFilePreviewShowsTheText()

  Scenario: access a shared link protected by password with an invalid password                # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-files-sharing-link.feature:128
    Given I act as John                                                                        # ActorContext::iActAs()
    And I am logged in                                                                         # LoginPageContext::iAmLoggedIn()
    And I share the link for "welcome.txt" protected by the password "abcdef"                  # FilesAppSharingContext::iShareTheLinkForProtectedByThePassword()
    And I write down the shared link                                                           # FilesAppSharingContext::iWriteDownTheSharedLink()
    When I act as Jane                                                                         # ActorContext::iActAs()
    And I visit the shared link I wrote down                                                   # PublicShareContext::iVisitTheSharedLinkIWroteDown()
    And I authenticate with password "fedcba"                                                  # PublicShareContext::iAuthenticateWithPassword()
      Password field in Authenticate page could not be found after 100 seconds (NoSuchElementException)
    Then I see that the current page is the Authenticate page for the shared link I wrote down # PublicShareContext::iSeeThatTheCurrentPageIsTheAuthenticatePageForTheSharedLinkIWroteDown()
    And I see that a wrong password for the shared file message is shown                       # PublicShareContext::iSeeThatAWrongPasswordForTheSharedFileMessageIsShown()

  Scenario: access a direct download shared link protected by password with a valid password                  # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-files-sharing-link.feature:139
    Given I act as John                                                                                       # ActorContext::iActAs()
    And I am logged in                                                                                        # LoginPageContext::iAmLoggedIn()
    And I share the link for "welcome.txt" protected by the password "abcdef"                                 # FilesAppSharingContext::iShareTheLinkForProtectedByThePassword()
    And I write down the shared link                                                                          # FilesAppSharingContext::iWriteDownTheSharedLink()
    When I act as Jane                                                                                        # ActorContext::iActAs()
    And I visit the direct download shared link I wrote down                                                  # PublicShareContext::iVisitTheDirectDownloadSharedLinkIWroteDown()
    And I see that the current page is the Authenticate page for the direct download shared link I wrote down # PublicShareContext::iSeeThatTheCurrentPageIsTheAuthenticatePageForTheDirectDownloadSharedLinkIWroteDown()
      Failed asserting that two strings are equal.
      --- Expected
      +++ Actual
      @@ @@
      -'http://acceptance-app-files-sharing-link/index.php/s/or34ZyXJtAGsfQq/authenticate/downloadShare'
      +'http://acceptance-app-files-sharing-link/index.php/s/or34ZyXJtAGsfQq/download'
    And I authenticate with password "abcdef"                                                                 # PublicShareContext::iAuthenticateWithPassword()
    And I see that the current page is the Authenticate page for the direct download shared link I wrote down # PublicShareContext::iSeeThatTheCurrentPageIsTheAuthenticatePageForTheDirectDownloadSharedLinkIWroteDown()

TESTS=acceptance, TESTS-ACCEPTANCE=app-files-tags

  • tests/acceptance/features/app-files-tags.feature:11
  • tests/acceptance/features/app-files-tags.feature:42
Show full log 
  Scenario: show the input field for tags in the details view after closing and opening the details view again # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-files-tags.feature:11
    Given I am logged in                                                                                       # LoginPageContext::iAmLoggedIn()
    And I open the details view for "welcome.txt"                                                              # FileListContext::iOpenTheDetailsViewFor()
    And I see that the details view is open                                                                    # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
    And I close the details view                                                                               # FilesAppContext::iCloseTheDetailsView()
    And I see that the details view is closed                                                                  # FilesAppContext::iSeeThatTheDetailsViewIsClosed()
    And I open the details view for "welcome.txt"                                                              # FileListContext::iOpenTheDetailsViewFor()
    And I see that the details view is open                                                                    # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
    When I open the input field for tags in the details view                                                   # FilesAppContext::iOpenTheInputFieldForTagsInTheDetailsView()
    Then I see that the input field for tags in the details view is shown                                      # FilesAppContext::iSeeThatTheInputFieldForTagsInTheDetailsViewIsShown()
      Failed asserting that false is true.

  Scenario: add tags using the dropdown in the details view                                 # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-files-tags.feature:42
    Given I am logged in as the admin                                                       # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I visit the settings page                                                           # SettingsMenuContext::iVisitTheSettingsPage()
    And I open the "Tag management" section                                                 # AppNavigationContext::iOpenTheSection()
    And I see that the button to select tags is shown                                       # SettingsContext::iSeeThatTheButtonToSelectTagsIsShown()
    And I create the tag "tag1" in the settings                                             # SettingsContext::iCreateTheTagInTheSettings()
    And I create the tag "tag2" in the settings                                             # SettingsContext::iCreateTheTagInTheSettings()
    And I create the tag "tag3" in the settings                                             # SettingsContext::iCreateTheTagInTheSettings()
    And I create the tag "tag4" in the settings                                             # SettingsContext::iCreateTheTagInTheSettings()
    And I see that the dropdown for tags in the settings eventually contains the tag "tag1" # SettingsContext::iSeeThatTheDropdownForTagsInTheSettingsEventuallyContainsTheTag()
    And I see that the dropdown for tags in the settings eventually contains the tag "tag2" # SettingsContext::iSeeThatTheDropdownForTagsInTheSettingsEventuallyContainsTheTag()
    And I see that the dropdown for tags in the settings eventually contains the tag "tag3" # SettingsContext::iSeeThatTheDropdownForTagsInTheSettingsEventuallyContainsTheTag()
    And I see that the dropdown for tags in the settings eventually contains the tag "tag4" # SettingsContext::iSeeThatTheDropdownForTagsInTheSettingsEventuallyContainsTheTag()
    And I log out                                                                           # SettingsMenuContext::iLogOut()
    And I am logged in                                                                      # LoginPageContext::iAmLoggedIn()
    And I open the details view for "welcome.txt"                                           # FileListContext::iOpenTheDetailsViewFor()
    And I open the input field for tags in the details view                                 # FilesAppContext::iOpenTheInputFieldForTagsInTheDetailsView()
    When I check the tag "tag2" in the dropdown for tags in the details view                # FilesAppContext::iCheckTheTagInTheDropdownForTagsInTheDetailsView()
    And I check the tag "tag4" in the dropdown for tags in the details view                 # FilesAppContext::iCheckTheTagInTheDropdownForTagsInTheDetailsView()
    Then I see that the tag "tag2" in the dropdown for tags in the details view is checked  # FilesAppContext::iSeeThatTheTagInTheDropdownForTagsInTheDetailsViewIsChecked()
    And I see that the tag "tag4" in the dropdown for tags in the details view is checked   # FilesAppContext::iSeeThatTheTagInTheDropdownForTagsInTheDetailsViewIsChecked()
    And I see that the input field for tags in the details view contains the tag "tag2"     # FilesAppContext::iSeeThatTheInputFieldForTagsInTheDetailsViewContainsTheTag()
      Failed asserting that false is true.
    And I see that the input field for tags in the details view contains the tag "tag4"     # FilesAppContext::iSeeThatTheInputFieldForTagsInTheDetailsViewContainsTheTag()

@MorrisJobke MorrisJobke merged commit aff13a2 into master Mar 11, 2019
@MorrisJobke MorrisJobke deleted the hint-user-docs-federation branch March 11, 2019 19:03
@MorrisJobke MorrisJobke mentioned this pull request Mar 20, 2019
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@schiessle schiessle Awaiting requested review from schiessle

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish feature: federation

Projects

None yet

Milestone

Nextcloud 16

Development

Successfully merging this pull request may close these issues.

3 participants

@MariusBluem @MorrisJobke @rullzer