Appconfig endpoint by nickvergessen · Pull Request #1452 · nextcloud/server

nickvergessen · 2016-09-19T21:46:53Z

Required for Password confirmation for some actions #1447

mention-bot · 2016-09-19T21:46:54Z

@nickvergessen, thanks for your PR! By analyzing the annotation information on this pull request, we identified @icewind1991, @LukasReschke and @bartv2 to be potential reviewers

MorrisJobke · 2016-09-19T23:27:32Z

@nickvergessen mumbled something about "I wanted to move this somehow in the provisioning API" ...
see CI ;)

MorrisJobke · 2016-09-20T13:41:47Z

@nickvergessen Fails ;)

PHP Fatal error:  Call to a member function getUpdater() on null in /drone/src/github.com/nextcloud/server/lib/private/Files/View.php on line 695

nickvergessen · 2016-09-20T14:40:40Z

@icewind1991

icewind1991 · 2016-10-11T13:59:00Z

I would prefer to return a promise from OCP.AppConfig.* instead of passing callbacks

nickvergessen · 2016-10-11T14:09:40Z

Can you just take care of fixing the failing phpunit tests which I didn't touch?

We can discuss promises later, although I don't feel a lot like breaking the current js API.

icewind1991 · 2016-10-12T11:53:35Z

PHP Warning: opendir(/drone/src/github.com/nextcloud/server/data-autotest): failed to open dir: No such file or directory in /drone/src/github.com/nextcloud/server/tests/lib/TestCase.php on line 300

Drone messing up?

MorrisJobke · 2016-10-12T12:00:18Z

Drone messing up?

I restarted it. Let's see

nickvergessen · 2016-10-20T12:31:50Z

I think I found the issue, will fix myself

codecov-io · 2016-10-20T15:24:11Z

Current coverage is 57.26% (diff: 71.18%)

Merging #1452 into master will increase coverage by 0.04%

@@             master      #1452   diff @@
==========================================
  Files          1074       1075     +1   
  Lines         61308      61661   +353   
  Methods        6848       6892    +44   
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          35084      35312   +228   
- Misses        26224      26349   +125   
  Partials          0          0

Diff Coverage	File Path
0%	apps/provisioning_api/appinfo/routes.php
•••••••• 80%	new ...visioning_api/lib/Controller/AppConfigController.php
•••••••••• 100%	core/routes.php
•••••••••• 100%	lib/private/legacy/template.php

Powered by Codecov. Last update 2b76d14...2aca56f

Signed-off-by: Joas Schilling <coding@schilljs.com>

nickvergessen · 2016-10-21T08:02:41Z

Rebased for #1822 and added php unit tests

@icewind1991 do you want to do the promise stuff in here, or can we do it in a different PR? I have no idea what that is and how it works.

MorrisJobke · 2016-10-21T13:17:44Z

core/js/public/appconfig.js

+			data: options.data || {},
+			success: options.success,
+			error: options.error
+		})


MorrisJobke · 2016-10-21T13:19:09Z

core/js/public/appconfig.js

+	 * @param {string} key
+	 * @param {Object} [options]
+	 * @param {function} [options.success]
+	 * @param {function} [options.error]


Proper documentation for the parameters would be nice

Well no documentation means nothing you should use?
Feel free to add something if you think it should be.

Signed-off-by: Joas Schilling <coding@schilljs.com>

MorrisJobke · 2016-10-24T19:23:46Z

apps/provisioning_api/appinfo/routes.php

+		['name' => 'AppConfig#getKeys', 'url' => '/api/v1/config/apps/{app}', 'verb' => 'GET'],
+		['name' => 'AppConfig#getValue', 'url' => '/api/v1/config/apps/{app}/{key}', 'verb' => 'GET'],
+		['name' => 'AppConfig#setValue', 'url' => '/api/v1/config/apps/{app}/{key}', 'verb' => 'POST'],
+		['name' => 'AppConfig#deleteKey', 'url' => '/api/v1/config/apps/{app}/{key}', 'verb' => 'DELETE'],


Do we really want to name this /api/ again?

This then results in stuff like http://localhost/server/ocs/v2.php/apps/provisioning_api/api/v1/config/apps/files_sharing/outgoing_server2server_share_enabled

this is what all ocs routes use

MorrisJobke · 2016-10-24T19:24:39Z

Beside the naming comment this is fine by me and works 👍

rullzer · 2016-10-25T08:56:41Z

LGTM

nickvergessen added enhancement 3. to review Waiting for reviews labels Sep 19, 2016

nickvergessen added this to the Nextcloud 11.0 milestone Sep 19, 2016

nickvergessen mentioned this pull request Sep 19, 2016

Password confirmation for some actions #1447

Merged

23 tasks

MorrisJobke added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Sep 19, 2016

nickvergessen force-pushed the appconfig-endpoint branch from df52a19 to 529162d Compare September 20, 2016 09:58

MorrisJobke added 3. to review Waiting for reviews 2. developing Work in progress and removed 2. developing Work in progress 3. to review Waiting for reviews labels Sep 20, 2016

nickvergessen mentioned this pull request Sep 21, 2016

Fix OC.AppConfig usage to public API nextcloud/survey_client#34

Merged

nickvergessen assigned icewind1991 Sep 26, 2016

nickvergessen mentioned this pull request Oct 7, 2016

Use the public AppConfig api nextcloud/announcementcenter#42

Merged

1 task

icewind1991 force-pushed the appconfig-endpoint branch from ce9ccc9 to 0aa3e92 Compare October 11, 2016 15:32

nickvergessen force-pushed the appconfig-endpoint branch from 950d457 to 496984d Compare October 17, 2016 12:07

nickvergessen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 17, 2016

nickvergessen unassigned icewind1991 Oct 17, 2016

MorrisJobke force-pushed the appconfig-endpoint branch from 496984d to 7da6e6a Compare October 20, 2016 11:16

nickvergessen mentioned this pull request Oct 20, 2016

Restore overwritten services after errors #1822

Merged

nickvergessen force-pushed the appconfig-endpoint branch from 7da6e6a to 4743fbc Compare October 20, 2016 13:32

nickvergessen added 3 commits October 21, 2016 09:09

Make AppConfig part of the public API

0b1fb18

Signed-off-by: Joas Schilling <coding@schilljs.com>

Switch to public API

103bf6d

Signed-off-by: Joas Schilling <coding@schilljs.com>

Add unit tests

0d878f9

Signed-off-by: Joas Schilling <coding@schilljs.com>

nickvergessen force-pushed the appconfig-endpoint branch from 4743fbc to 0d878f9 Compare October 21, 2016 08:00

MorrisJobke reviewed Oct 21, 2016

View reviewed changes

Fix missing semicolon

2aca56f

Signed-off-by: Joas Schilling <coding@schilljs.com>

MorrisJobke reviewed Oct 24, 2016

View reviewed changes

nickvergessen merged commit 890f752 into master Oct 25, 2016

nickvergessen deleted the appconfig-endpoint branch October 25, 2016 08:57

Uh oh!

Conversation

nickvergessen commented Sep 19, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mention-bot commented Sep 19, 2016

Uh oh!

MorrisJobke commented Sep 19, 2016 • edited by nickvergessen Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MorrisJobke commented Sep 20, 2016

Uh oh!

nickvergessen commented Sep 20, 2016

Uh oh!

icewind1991 commented Oct 11, 2016

Uh oh!

nickvergessen commented Oct 11, 2016

Uh oh!

icewind1991 commented Oct 12, 2016

Uh oh!

MorrisJobke commented Oct 12, 2016

Uh oh!

nickvergessen commented Oct 20, 2016

Uh oh!

codecov-io commented Oct 20, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Current coverage is 57.26% (diff: 71.18%)

Uh oh!

nickvergessen commented Oct 21, 2016

Uh oh!

MorrisJobke Oct 21, 2016

Choose a reason for hiding this comment

Uh oh!

nickvergessen Oct 24, 2016

Choose a reason for hiding this comment

Uh oh!

MorrisJobke Oct 21, 2016

Choose a reason for hiding this comment

Uh oh!

nickvergessen Oct 24, 2016

Choose a reason for hiding this comment

Uh oh!

MorrisJobke Oct 24, 2016

Choose a reason for hiding this comment

Uh oh!

nickvergessen Oct 24, 2016

Choose a reason for hiding this comment

Uh oh!

MorrisJobke commented Oct 24, 2016

Uh oh!

rullzer commented Oct 25, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

nickvergessen commented Sep 19, 2016 •

edited

Loading

MorrisJobke commented Sep 19, 2016 •

edited by nickvergessen

Loading

codecov-io commented Oct 20, 2016 •

edited

Loading