Move updatenotifications to unified webpack#14232
Conversation
4abaca6 to
184bcac
Compare
|
@rullzer I've pushed better a fix for the hot reload issue, which causes differences in the bundled files. The actual issue is that webpack doesn't set the NODE_ENV variable when setting the mode to 'production' so vue-loader was still behaving as if it was in development mode. (https://github.com/webpack/webpack/issues/7074) Setting the environment variable as well seems to fix that: b6335e9 |
|
@juliushaertl does this impact the bundle size ? Shall we edit all of our configs? |
|
@juliushaertl nice catch. Lets fix this in a seperate PR so we keep it clean. See #14258 |
I didn't found any huge difference, for the server bundles it was like <1kb less. |
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
184bcac to
d6ba420
Compare
|
Rebased. Ready to get in! |
Signed-off-by: Roeland Jago Douma roeland@famdouma.nl