Closed
Conversation
Fixes #11393 Signed-off-by: Aastha Gupta <aastha.gupta4104@gmail.com> Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
MorrisJobke
requested changes
Jan 30, 2019
Member
MorrisJobke
left a comment
There was a problem hiding this comment.
The problem with this approach is that you can't change a person to the default quota anymore. It will always set it to the specific one. Thus I would say that it needs to be done the other way around: There is still the default quota entry but it will show inline the amount that it currently is set to.
Member
|
@ChristophWurst Any news here? |
Member
Author
|
I have no clue about the code tbh. I just tried to clean up #11393 to finally get it merged. |
Member
|
Let's close it for now. We can reopen at any time, when somebody want to work on this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11393
This is a rebased and fixed version of #12087. I have not tested the patch.
Supersedes #12087 by @AasthaGupta :)