Skip to content

Fix app navigation flickering on hover#13574

Merged
MorrisJobke merged 1 commit intonextcloud:masterfrom
alion300:master
Jan 16, 2019
Merged

Fix app navigation flickering on hover#13574
MorrisJobke merged 1 commit intonextcloud:masterfrom
alion300:master

Conversation

@alion300
Copy link
Contributor

@alion300 alion300 commented Jan 14, 2019

i change the file by xaviterando done and fix
and i will do pull request to the solution becouse xavirando did pull request to him self

@alion300
the bug number nextcloud#13263 fixed by the xavierando user
6ad1a8f 
i change the file by xaviterando done and fix
and i will do pull request to the solution becouse xavirando did pull request to him self
@ChristophWurst
Copy link
Member

ChristophWurst commented Jan 14, 2019

Ref #13263

@ChristophWurst
Copy link
Member

ChristophWurst commented Jan 14, 2019

@nickvergessen isn't that the bug that annoyed you? ;)

@ChristophWurst ChristophWurst added bug design Design, UI, UX, etc. 3. to review Waiting for reviews labels Jan 14, 2019
@ChristophWurst ChristophWurst added this to the Nextcloud 16 milestone Jan 14, 2019
@juliusknorr
Copy link
Member

juliusknorr commented Jan 14, 2019

/backport to stable15

@juliusknorr
Copy link
Member

juliusknorr commented Jan 14, 2019

Thanks a lot for your contribution @alion300 🚀

There is only one thing missing - you need to add a sign-off message to the commits you made. Read more about this in https://github.com/nextcloud/server/blob/master/.github/CONTRIBUTING.md#sign-your-work

cc @xaviterando As he was the original author of the change.

@juliusknorr
Copy link
Member

juliusknorr commented Jan 14, 2019

CI failure unrelated

@juliusknorr juliusknorr changed the title the bug number #13263 fixed by the xavierando user Fix app navigation flickering on hover Jan 14, 2019
MorrisJobke
MorrisJobke approved these changes Jan 16, 2019
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke MorrisJobke merged commit 355d69e into nextcloud:master Jan 16, 2019
@welcome
Copy link

welcome bot commented Jan 16, 2019

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22
Most developers hang out on IRC. So join #nextcloud-dev on Freenode for a chat!

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jan 16, 2019
Merged
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Jan 16, 2019

backport to stable15 in #13625

@jancborchardt
Copy link
Member

jancborchardt commented Jan 23, 2019

Great fix @alion300! :) Welcome to Nextcloud – any design fixes are always very welcome, if you like have a look at our Design page for more pointers. 🎉

@MorrisJobke MorrisJobke mentioned this pull request Mar 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug design Design, UI, UX, etc.

Projects

None yet

Milestone

Nextcloud 16

Development

Successfully merging this pull request may close these issues.

5 participants

@alion300 @ChristophWurst @juliusknorr @jancborchardt @MorrisJobke