Skip to content

CSP: Allow fonts to be provided in data#13403

Merged
rullzer merged 1 commit intomasterfrom
csp/allow_data_fonts
Jan 7, 2019
Merged

CSP: Allow fonts to be provided in data#13403
rullzer merged 1 commit intomasterfrom
csp/allow_data_fonts

Conversation

@rullzer
Copy link
Member

@rullzer rullzer commented Jan 7, 2019

Required for the dark mode of the vue components.

@rullzer rullzer added the 3. to review Waiting for reviews label Jan 7, 2019
@rullzer rullzer added this to the Nextcloud 16 milestone Jan 7, 2019
@rullzer
Copy link
Member Author

rullzer commented Jan 7, 2019

/backport to stable15

@skjnldsv skjnldsv mentioned this pull request Jan 7, 2019
Merged
ChristophWurst
ChristophWurst approved these changes Jan 7, 2019
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 7, 2019
@skjnldsv
Copy link
Member

skjnldsv commented Jan 7, 2019 

7) Test\AppFramework\Http\ContentSecurityPolicyTest::testGetPolicyDisallowScriptDomainMultipleStacked
Failed asserting that two strings are identical.

@rullzer rullzer added 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish labels Jan 7, 2019
@rullzer
Copy link
Member Author

rullzer commented Jan 7, 2019

Right. I'll fix the tests 🙈

@rullzer rullzer force-pushed the csp/allow_data_fonts branch from 159f788 to 983cd04 Compare January 7, 2019 12:58
@rullzer
CSP: Allow fonts to be provided in data
64244e1 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer rullzer force-pushed the csp/allow_data_fonts branch from 983cd04 to 64244e1 Compare January 7, 2019 14:07
@rullzer rullzer merged commit 6e4c5a6 into master Jan 7, 2019
@rullzer rullzer deleted the csp/allow_data_fonts branch January 7, 2019 14:39
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jan 7, 2019
Merged
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Jan 7, 2019

backport to stable15 in #13411

@raimund-schluessler
Copy link
Member

raimund-schluessler commented Jan 10, 2019

Could this be backported to stable14 as well? Otherwise some apps will have to require NC15 just for the datepicker component.

@rullzer
Copy link
Member Author

rullzer commented Jan 10, 2019

@raimund-schluessler I discussed this with @skjnldsv. THe trouble is of course that if an app is 14 compliant. It might still do 💥 if a user is not on the latest patch level...

@raimund-schluessler
Copy link
Member

raimund-schluessler commented Jan 10, 2019

@raimund-schluessler I discussed this with @skjnldsv. THe trouble is of course that if an app is 14 compliant. It might still do 💥 if a user is not on the latest patch level...

True, but that is also the case for 15.

skjnldsv referenced this pull request in nextcloud/contacts Jan 10, 2019
@dependabot
Merge pull request #837 from nextcloud/dependabot/npm_and_yarn/nextcl…
e1ec0b4 
…oud-vue-0.5.0
@skjnldsv
Copy link
Member

skjnldsv commented Jan 10, 2019

let's continue on nextcloud-libraries/nextcloud-vue#193 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@MorrisJobke MorrisJobke Awaiting requested review from MorrisJobke

Assignees

No one assigned

Labels

2. developing Work in progress

Projects

None yet

Milestone

Nextcloud 16

Development

Successfully merging this pull request may close these issues.

4 participants

@rullzer @skjnldsv @raimund-schluessler @ChristophWurst