Skip to content

Fix loginflow with apptoken enter on iOS#13363

Merged
MorrisJobke merged 1 commit intomasterfrom
fix/loginflow_apptoken_ios
Jan 4, 2019
Merged

Fix loginflow with apptoken enter on iOS#13363
MorrisJobke merged 1 commit intomasterfrom
fix/loginflow_apptoken_ios

Conversation

@rullzer
Copy link
Member

@rullzer rullzer commented Jan 4, 2019 •
edited
Loading

It seems iOS doesn't like us to change the location. So now we submit it
to the server that geneartes the redirect.

So now on iOS devices

  1. add your server
  2. click on Alternative log in using app token
  3. enter your username + a generate apptoken
  4. click Grant Access

Before: Nothing happens
Now: Proper redirect

@rullzer rullzer added the 3. to review Waiting for reviews label Jan 4, 2019
@rullzer rullzer added this to the Nextcloud 16 milestone Jan 4, 2019
MorrisJobke
MorrisJobke approved these changes Jan 4, 2019
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke MorrisJobke mentioned this pull request Jan 4, 2019
Merged
3 tasks
@MorrisJobke
Copy link
Member

MorrisJobke commented Jan 4, 2019

/backport to stable15

@MorrisJobke
Copy link
Member

MorrisJobke commented Jan 4, 2019

/backport to stable14

@MorrisJobke
Copy link
Member

MorrisJobke commented Jan 4, 2019

/backport to stable13

@rullzer
Fix loginflow with apptoken enter on iOS
e6ac233 
It seems iOS doesn't like us to change the location. So now we submit it
to the server that geneartes the redirect.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer rullzer force-pushed the fix/loginflow_apptoken_ios branch from 5af7172 to e6ac233 Compare January 4, 2019 20:51
blizzz
blizzz approved these changes Jan 4, 2019
View reviewed changes
Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@blizzz blizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 4, 2019
@MorrisJobke MorrisJobke merged commit 076f6b8 into master Jan 4, 2019
@MorrisJobke MorrisJobke deleted the fix/loginflow_apptoken_ios branch January 4, 2019 21:42
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jan 4, 2019
Merged
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Jan 4, 2019

backport to stable15 in #13370

@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Jan 4, 2019

backport to stable14 in #13371

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jan 4, 2019
Merged
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Jan 4, 2019

The backport to stable13 failed. Please do this backport manually.

@MorrisJobke MorrisJobke mentioned this pull request Jan 4, 2019
Merged
@MorrisJobke
Copy link
Member

MorrisJobke commented Jan 4, 2019

backport to stable13 in #13374

@MorrisJobke MorrisJobke mentioned this pull request Feb 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@blizzz blizzz blizzz approved these changes

@mario mario Awaiting requested review from mario

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish

Projects

None yet

Milestone

Nextcloud 16

Development

Successfully merging this pull request may close these issues.

3 participants

@rullzer @MorrisJobke @blizzz