unbundle user_external to release it via appstore#13225
Merged
MorrisJobke merged 1 commit intomasterfrom Jan 3, 2019
Merged
Conversation
Signed-off-by: Jonas Sulzer <jonas@violoncello.ch>
Member
Author
|
/backport to stable15 |
5 tasks
skjnldsv
approved these changes
Dec 21, 2018
Contributor
|
Would be nice to have a fixed version out soon. Seems to break quite some installations and fixing it seems trivial. |
Member
Author
|
@duritong it's still holliday time, so yeah, as soon as possible .... |
MorrisJobke
approved these changes
Jan 3, 2019
|
backport to stable15 in #13329 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as for nextcloud/user_external#22 we want to remove user_external from the build script and update it independently via appstore. As it's broken for 15.0.0 anyway (#12506) we want to increase the min-version to 15 and publish it via appstore. So it should not generate any problem (if shipped and available via appstore).
I only found the
shipped.json. Are there other things to change or does the build script only take the list fromshipped.json? @MorrisJobkecc @nextcloud/user_external @jancborchardt
Signed-off-by: Jonas Sulzer jonas@violoncello.ch