Merged
Conversation
This was referenced Nov 12, 2018
Closed
rullzer
approved these changes
Nov 23, 2018
Member
rullzer
left a comment
There was a problem hiding this comment.
Can't really test. But makes sense.
MorrisJobke
approved these changes
Nov 28, 2018
Contributor
Author
|
I will have a look at the failed tests later. |
70a8396 to
e84fcc3
Compare
Contributor
Author
|
@rullzer @MorrisJobke mind to review again? Tests are working for me now. |
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
1b46f04 to
4a2c56b
Compare
ChristophWurst
approved these changes
Nov 29, 2018
Member
ChristophWurst
left a comment
There was a problem hiding this comment.
Couldn't test but code looks good!
Member
|
/backport to stable15 |
|
backport to stable15 in #12736 |
Member
|
/backport to stable14 |
|
The backport to stable14 failed. Please do this backport manually. |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #11454
Close #11281
-oifrom pipe mode (i'm unsure if the switch is available on any platform)cc @cwiedmann @duke-m