Skip to content

Enable sorting in file picker#12350

Merged
MorrisJobke merged 3 commits intomasterfrom
filepicker-sorting
Nov 20, 2018
Merged

Enable sorting in file picker#12350
MorrisJobke merged 3 commits intomasterfrom
filepicker-sorting

Conversation

@juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Nov 8, 2018

Fixes #645

This allows sorting the entries in the file picker by name, size or mtime.

List view:
image

Grid view:
image

skjnldsv
skjnldsv approved these changes Nov 8, 2018
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working fine here!

@MorrisJobke
Copy link
Member

MorrisJobke commented Nov 13, 2018 •
edited by juliusknorr
Loading

  • header also shown in the empty file list
    bildschirmfoto 2018-11-13 um 16 27 47
  • loading spinner is placed over the header
    bildschirmfoto 2018-11-13 um 16 27 52

@MorrisJobke MorrisJobke added this to the Nextcloud 15 milestone Nov 13, 2018
@MorrisJobke MorrisJobke mentioned this pull request Nov 13, 2018
Merged
24 tasks
@MorrisJobke
Copy link
Member

MorrisJobke commented Nov 14, 2018

@juliushaertl Moved to 16, but we maybe want to back port this anyways, right?

@rullzer
Copy link
Member

rullzer commented Nov 14, 2018

@MorrisJobke yes that is right

@juliusknorr
Allow sorting in the file picker
3e11337 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Flip sort indicators
916cdb2 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Properly align loading indicator when switching folders
5e5cced 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Copy link
Member Author

juliusknorr commented Nov 16, 2018

@MorrisJobke Fixed.

MorrisJobke
MorrisJobke approved these changes Nov 20, 2018
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke MorrisJobke merged commit a9de88e into master Nov 20, 2018
@MorrisJobke MorrisJobke deleted the filepicker-sorting branch November 20, 2018 12:35
@MorrisJobke
Copy link
Member

MorrisJobke commented Nov 20, 2018

/backport to stable14

@MorrisJobke
Copy link
Member

MorrisJobke commented Nov 20, 2018

/backport to stable13

@rullzer
Copy link
Member

rullzer commented Nov 20, 2018

The backport failed in a way the bot did not handle it properly. I'll look into that

@MorrisJobke MorrisJobke mentioned this pull request Nov 22, 2018
Merged
7 tasks
@MorrisJobke
Copy link
Member

MorrisJobke commented Nov 22, 2018

/backport to stable14

@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Nov 22, 2018

The backport to stable13 failed. Please do this backport manually.

@juliusknorr
Copy link
Member Author

juliusknorr commented Nov 29, 2018

We'll not backport this for now as discussed with @MorrisJobke

@jancborchardt jancborchardt mentioned this pull request Feb 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@rullzer rullzer Awaiting requested review from rullzer

@danxuliu danxuliu Awaiting requested review from danxuliu

Assignees

No one assigned

Labels

3. to review Waiting for reviews enhancement feature: filepicker

Projects

None yet

Milestone

Nextcloud 15

Development

Successfully merging this pull request may close these issues.

4 participants

@juliusknorr @MorrisJobke @rullzer @skjnldsv