Add "password" parameter to the response data of link shares#12324
Merged
MorrisJobke merged 1 commit intomasterfrom Nov 7, 2018
Merged
Conversation
Due to legacy reasons the password of link shares was returned in the "share_with" and "share_with_displayname" parameters of the response data. Now a proper "password" parameter is returned too; the old "share_with" and "share_with_displayname" parameters are kept, although deprecated, and they will be removed in a future version of Nextcloud. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
rullzer
approved these changes
Nov 7, 2018
Member
rullzer
left a comment
There was a problem hiding this comment.
We should probably update the documentation as well then
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to legacy reasons the password of link shares was returned in the
share_withandshare_with_displaynameparameters of the response data. Now a properpasswordparameter is returned too.@camilasan @marinofaggiana @rullzer @tobiasKaminsky No need to hurry updating the clients, the old
share_withandshare_with_displaynameparameters are kept for now; they will be removed in a future version of Nextcloud, but only once it is safe to do it, of course :-)