Merged
Conversation
|
i changed the jail.php like this: but after reloading my Nextcloud-Page, the erros still occures. |
Member
Author
|
Replace it with public function getUnjailedPath($path) {
if ($path === '') {
return $this->rootPath;
} else {
return Filesystem::normalizePath($this->rootPath . '/' . $path);
}
} |
Member
Red lines in the git diff means "removed line" and green "added line". |
icewind1991
approved these changes
Oct 11, 2018
Fixes #11637 If we do not normalize the unjailed path we might end up with a path like files/user/folder/. which can break on objectstores Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
8077a27 to
51e96dc
Compare
|
Have made this fix in a second instance and it works likewise. Perfect! |
nickvergessen
approved these changes
Oct 11, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Fixes #11637
When writing a file to the root of a shared storage we have to obtain
creatable information on the root of the share. However getting the
dirname of the path then results in
.. Passing this along potentiallybreaks.
For example objectstores do not have the same hierachy as a normal fs.
So the file
.doesn't mean anything in that context.Signed-off-by: Roeland Jago Douma roeland@famdouma.nl