Add icon-black-white mixin to automatically generate icon classes#10311
Merged
MorrisJobke merged 2 commits intomasterfrom Jul 20, 2018
Merged
Add icon-black-white mixin to automatically generate icon classes#10311MorrisJobke merged 2 commits intomasterfrom
MorrisJobke merged 2 commits intomasterfrom
Conversation
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Member
|
Works in IE11 fine 👍 |
pixelipo
approved these changes
Jul 20, 2018
skjnldsv
approved these changes
Jul 20, 2018
Member
Author
|
Ok let me adjust it that way for the other icon classes as well 😉 |
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Member
Author
|
Ready for review. I moved all icon classes that match the pattern, however there are some that don't so I kept them unchanged for now, so we don't break anything at this point. We should consider unifying this for 15 maybe, but I think we should announce that early, since we don't have any process for deprecating css classes. I've tested this in Chrome, Firefox and IE11. Drop shadows are also kept on icons which use it, so the look is still the same for apps like talk that use the server icons. |
MorrisJobke
approved these changes
Jul 20, 2018
Member
MorrisJobke
left a comment
There was a problem hiding this comment.
Tested and now icons work in IE11 for the gallery 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will fix #8702 by automatically generating proper classes for black and white icons.
@include icon-black-white('close', 'actions', $color-black, 1, true);will generate the following css:The css vars are set with the correct URL as this was done in #9984
What do you think about that @skjnldsv @pixelipo @nextcloud/designers