Add Quick-Access to favorite folder in left sidepanel in files-app

[newhinton]

It would be a good feature to add a quick way to access favorite folders on the "main" view of the file app. Most Fileexplorer have such a feature to access often used directories quickly.

I have already started implementing this in the files-app, i am creating this Issue mostly to gather feedback and to check if the files-app is the right place to implement this (in opposition to an additional app wich extends the original app ( I dont know how to do this)).

This feature is going to be toggleable.

[c0fe]

This looks like a pretty useful feature to be honest.

@MorrisJobke @rullzer any thoughts?

[MorrisJobke]

Cc @nextcloud/designers

[enoch85]

👍

[newhinton]

I have added a pull request.

The only thing which does not properly work, is the initial State of the checkbox which enables this functionality. It is properly set, but the initial state is always unchecked, regardless of the true value.

[newhinton]

The trashbin and quota-indicator are list-elements which are pushed down to "dock" on the settings button. If the folderlist exceeds the size of the sidebar, it gets a scrollbar, which is fine.
The problem: Quota and Trashbin are listelements and therefore they are pushed "under" the settingsbutton. Should they stay over that button, or is it acceptable to let them slide down?

[skjnldsv]

@newhinton no, it is the expected behaviour :)
This is intended for better accessibility on small height views which reduced the total height and show too few of the first navigations items.

[juliusknorr]

While I like the idea of having favorite folders directly accessible, I fear that this will clutter the UI too much once you have more folders marked as favorite. Maybe we could just limit it to first level favorite folders or have a hard limit of 3-4 entries? Anyhow having a limit would only make sense if we could show the most recently used folders or something similar.

cc @jancborchardt

[skjnldsv]

We also supports collapsible entries, we could go for this?

[newhinton]

A stylechange could help differentiate between menu-entries and favorites. Making favorites smaller could clean up the UI, but I'll need to try that out and see if it works

[c0fe]

@juliushaertl what about making this into an accordion style menu where if you click you will get the full list? or perhaps show a number of items then a button "show more"?

[newhinton]

Also, this is not enabled by default, so the user needs to actively decide to "clutter" his UI, so it would be an active decision by the user