Conversation
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Codecov Report
@@ Coverage Diff @@
## stable12 #6649 +/- ##
==============================================
+ Coverage 53.75% 53.76% +<.01%
Complexity 22541 22541
==============================================
Files 1383 1383
Lines 86539 86539
Branches 1328 1328
==============================================
+ Hits 46523 46528 +5
+ Misses 40016 40011 -5
|
jancborchardt
approved these changes
Sep 26, 2017
Member
jancborchardt
left a comment
There was a problem hiding this comment.
Looks good! Should we also directly add the border-radius variable for 3px?
Member
Author
|
@jancborchardt Mind to do that on master and add the box shadow too? :) |
Member
|
backporting shouldn’t hurt I guess |
MorrisJobke
approved these changes
Sep 26, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #6372 we have a variable that future apps may need (to avoid fallback 😄 )
I think this should be backported. What do you think? @MorrisJobke @karlitschek