[19.0] Broken dbpassword-toggle button

[J0WI]

How to use GitHub

• Please use the 👍 reaction to show that you are affected by the same issue.
• Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
• Subscribe to receive notifications on status change and new comments.

The dbpassword-toggle button is broken in current 19.0-beta. It works fine in 18.0.

Steps to reproduce

1. fetch the sources for Nextcloud 19 on a webserver an access from a browser (Mozilla Firefox)
2. toggle the Database to something else than SQLite
3. provide any database password and toggle the eye symbol (dbpassword-toggle)

Expected behaviour

password should be shown in clear text

Actual behaviour

nothing happens

no logs or error are shown for this action.

[MarcinWieczorek]

Confirmed.
I think commit bba26cb introduced the bug when installations.js and other files were merged into core/src/install.js but the code regarding the password ($('#dbpass').showPassword().keyup();) is missing.

Edit: I confirmed that the fix is working (I pasted missing code at the end of minified file). If someone could explain to me how the js file gets minified in the docker image then I will test it once again and provide a PR.

[J0WI]

🏓 @nextcloud/javascript

[MarcinWieczorek]

@J0WI I'm not sure what it's supposed to point at, the url is invalid.