PHP Warning - vsprintf(): Too few arguments in L10NString.php:79

[Deltachaos]

When I look in my server logs i have several appearances of this warning:

vsprintf(): Too few arguments at /opt/nextcloud/lib/private/L10N/L10NString.php#79

Probably happens if $this->parameters is empty. Simple check if $this->parameters is empty, should solve it.

Server configuration

Operating system: Debian GNU/Linux 10 (buster)

Web server: nginx

Database: MySQL

PHP version: 7.3

Nextcloud version: 18.0.3

[kesselb]

Looks like some app is calling the translate function in a wrong way. I don't see how your suggestion would fix that warning. vsprintf throws that warning if the string to translate has 2 (for example) parameters but only one is passed.

Mind to add the missing information from the issue template? Configuration, List of Apps and a complete log message?

[anoadragon453]

I was getting this repeatedly until I disabled the 'Notifications' app.

I'm using the latest stable Nextcloud snap, with caddyv2 as a reverse proxy in front on Ubuntu 18.04.4.

[DanScharon]

seeing the same log entries. Complete (but scrubbed) log entries:

{"reqId":"n4xxrYreeB6FgfGJiSZC","level":3,"time":"2020-05-28T19:01:24+02:00","remoteAddr":"<scrubbed>","user":"<scrubbed>","app":"PHP","method":"GET","url":"/ocs/v2.php/apps/notifications/api/v2/notifications?format=json","message":"vsprintf(): Too few arguments at /var/www/nextcloud/lib/private/L10N/L10NString.php#79","userAgent":"Mozilla/5.0 (Windows) mirall/2.6.4stable-Win64 (build 20200303) (Nextcloud)","version":"18.0.4.2"}
{"reqId":"n4xxrYreeB6FgfGJiSZC","level":3,"time":"2020-05-28T19:01:24+02:00","remoteAddr":"<scrubbed>","user":"<scrubbed>","app":"PHP","method":"GET","url":"/ocs/v2.php/apps/notifications/api/v2/notifications?format=json","message":"Method OC\\L10N\\L10NString::__toString() must return a string value at /var/www/nextcloud/lib/private/L10N/L10N.php#109","userAgent":"Mozilla/5.0 (Windows) mirall/2.6.4stable-Win64 (build 20200303) (Nextcloud)","version":"18.0.4.2"}

{"reqId":"0WaT6uFb61S3EBgoO3Ca","level":3,"time":"2020-05-28T19:03:19+02:00","remoteAddr":"<scrubbed>","user":"<scrubbed>","app":"PHP","method":"GET","url":"/ocs/v2.php/apps/notifications/api/v2/notifications?format=json","message":"vsprintf(): Too few arguments at /var/www/nextcloud/lib/private/L10N/L10NString.php#79","userAgent":"Mozilla/5.0 (Macintosh) mirall/2.5.2git (build 20190319) (Nextcloud)","version":"18.0.4.2"}
{"reqId":"0WaT6uFb61S3EBgoO3Ca","level":3,"time":"2020-05-28T19:03:19+02:00","remoteAddr":"<scrubbed>","user":"<scrubbed>","app":"PHP","method":"GET","url":"/ocs/v2.php/apps/notifications/api/v2/notifications?format=json","message":"Method OC\\L10N\\L10NString::__toString() must return a string value at /var/www/nextcloud/lib/private/L10N/L10N.php#109","userAgent":"Mozilla/5.0 (Macintosh) mirall/2.5.2git (build 20190319) (Nextcloud)","version":"18.0.4.2"}

In all cases it is always the same user (with two different clients). The Nextcloud instance has no default language set but the user in question explicitly set his/her to "English (US)".

[kesselb]

Index: lib/private/L10N/L10NString.php
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- lib/private/L10N/L10NString.php	(revision b9222ff596e93330800852c02a3a114977ec4127)
+++ lib/private/L10N/L10NString.php	(date 1590687122606)
@@ -76,7 +76,19 @@
 
 		// Replace %n first (won't interfere with vsprintf)
 		$text = str_replace('%n', (string)$this->count, $text);
-		return vsprintf($text, $this->parameters);
+
+		// Replace placeholder
+		$result = vsprintf($text, $this->parameters);
+
+		if ($result === false) {
+			\OC::$server->getLogger()->error('Unable to format "{text}" with "{parameters}"', [
+				'text' => $text,
+				'parameters' => implode(',', $this->parameters)
+			]);
+			return '';
+		}
+
+		return $result;
 	}

One of you mind to try the above patch. It should log the faulty string.

[DanScharon]

thank you! Yes, it logs the faulty string:

{"reqId":"DZeQUpF6uOGmEZhTLcyq","level":3,"time":"2020-05-29T19:39:36+02:00","remoteAddr":"<scrubbed>","user":"user222341","app":"PHP","method":"GET","url":"/ocs/v2.php/apps/notifications/api/v2/notifications?format=json","message":"vsprintf(): Too few arguments at /var/www/nextcloud/lib/private/L10N/L10NString.php#81","userAgent":"Mozilla/5.0 (Macintosh) mirall/2.5.2git (build 20190319) (Nextcloud)","version":"18.0.4.2"}
{"reqId":"DZeQUpF6uOGmEZhTLcyq","level":3,"time":"2020-05-29T19:39:36+02:00","remoteAddr":"<scrubbed>","user":"user222341","app":"no app in context","method":"GET","url":"/ocs/v2.php/apps/notifications/api/v2/notifications?format=json","message":"Unable to format \"You received \"%3$s\" as a remote share from %4$s (%1$s)\" with \"user233440@https://cloud.scrubbed.com/,user233440@https://cloud.scrubbed.com/,IK3 WS19-20\"","userAgent":"Mozilla/5.0 (Macintosh) mirall/2.5.2git (build 20190319) (Nextcloud)","version":"18.0.4.2"}

Btw, the logged notification looks like another user from the same instance tried to share something with the notified user via remote share 🙈

[anoadragon453]

Ahh, yes, I also had pending remote shares that I couldn't accept due to this bug!

[kesselb]

cc @rullzer @nickvergessen

[nickvergessen]

Looks like the language needs fixing in transifex

[kesselb]

server/apps/federatedfilesharing/lib/Notifier.php

Lines 127 to 129 in cb05782

	$notification->setParsedSubject(
	$l->t('You received "%3$s" as a remote share from %4$s (%1$s)', $params)
	);

I'm not sure ;)

%1$s user233440@https://cloud.scrubbed.com/
%2$s user233440@https://cloud.scrubbed.com/
%3$s IK3 WS19-20
%4$s is missing?

[nickvergessen]

Right, 17fae47 is working only for new shares. Couple of lines above in the other if 4 and 3 get a fallback and that is missing here.