NC18rc1 - php7.4 report

[jookk]

debian 10
php7.4-fpm
nginx 1.17.7

[PHP] Error: Trying to access array offset on value of type int at /var/www/nextcloud/lib/private/AppFramework/OCS/BaseResponse.php#129

GET /ocs/v2.php/cloud/capabilities?
from x.x.x.x by user at 2020-01-06T09:15:14+01:00

[kesselb]

Are you able to track this down to a specific action?

Index: lib/private/AppFramework/OCS/BaseResponse.php
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- lib/private/AppFramework/OCS/BaseResponse.php	(revision c3124dc36f635bde7994673763c7c1913336a5e9)
+++ lib/private/AppFramework/OCS/BaseResponse.php	(date 1578325784357)
@@ -126,6 +126,9 @@
 	 */
 	protected function toXML(array $array, \XMLWriter $writer) {
 		foreach ($array as $k => $v) {
+			if (is_int($k)) {
+				throw new \Exception('$k is integer');
+			}
 			if ($k[0] === '@') {
 				$writer->writeAttribute(substr($k, 1), $v);
 				continue;

Should emit a exception with a stack trace. It's probably enough to use if (strpos($k, '@') === 0) { for the check.