BirthdayService expects parameter 1 to be string, object given

[skjnldsv]

@georgehrke

Infos

• NC 17
• Request ID: ocBQc7pD89YyCCf2IcUw
• Type: TypeError
• Code: 0
• Message: DateTime::__construct() expects parameter 1 to be string, object given
• File: /var/www/html/apps/dav/lib/CalDAV/BirthdayService.php
• Line: 246

Trace

#0 /var/www/html/apps/dav/lib/CalDAV/BirthdayService.php(246): DateTime->__construct(Object(Sabre\VObject\Property\VCard\Date))
#1 /var/www/html/apps/dav/lib/CalDAV/BirthdayService.php(368): OCA\DAV\CalDAV\BirthdayService->buildDateFromContact('BEGIN:VCARD\r\nVE...', 'BDAY', '')
#2 /var/www/html/apps/dav/lib/CalDAV/BirthdayService.php(125): OCA\DAV\CalDAV\BirthdayService->updateCalendar('BA0E8376-9842-4...', 'BEGIN:VCARD\r\nVE...', Array, 6, Array)
#3 /var/www/html/apps/dav/lib/AppInfo/Application.php(128): OCA\DAV\CalDAV\BirthdayService->onCardChanged(1, 'BA0E8376-9842-4...', 'BEGIN:VCARD\r\nVE...')
#4 /var/www/html/3rdparty/symfony/event-dispatcher/EventDispatcher.php(212): OCA\DAV\AppInfo\Application->OCA\DAV\AppInfo\{closure}(Object(Symfony\Component\EventDispatcher\GenericEvent), '\\OCA\\DAV\\CardDA...', Object(Symfony\Component\EventDispatcher\EventDispatcher))
#5 /var/www/html/3rdparty/symfony/event-dispatcher/EventDispatcher.php(44): Symfony\Component\EventDispatcher\EventDispatcher->doDispatch(Array, '\\OCA\\DAV\\CardDA...', Object(Symfony\Component\EventDispatcher\GenericEvent))
#6 /var/www/html/lib/private/EventDispatcher/SymfonyAdapter.php(59): Symfony\Component\EventDispatcher\EventDispatcher->dispatch('\\OCA\\DAV\\CardDA...', Object(Symfony\Component\EventDispatcher\GenericEvent))
#7 /var/www/html/apps/dav/lib/CardDAV/CardDavBackend.php(701): OC\EventDispatcher\SymfonyAdapter->dispatch('\\OCA\\DAV\\CardDA...', Object(Symfony\Component\EventDispatcher\GenericEvent))
#8 /var/www/html/3rdparty/sabre/dav/lib/CardDAV/Card.php(96): OCA\DAV\CardDAV\CardDavBackend->updateCard('1', 'BA0E8376-9842-4...', 'BEGIN:VCARD\r\nVE...')
#9 /var/www/html/3rdparty/sabre/dav/lib/DAV/Server.php(1130): Sabre\CardDAV\Card->put('BEGIN:VCARD\r\nVE...')
#10 /var/www/html/3rdparty/sabre/dav/lib/DAV/CorePlugin.php(513): Sabre\DAV\Server->updateFile('addressbooks/us...', 'BEGIN:VCARD\r\nVE...', NULL)
#11 [internal function]: Sabre\DAV\CorePlugin->httpPut(Object(Sabre\HTTP\Request), Object(Sabre\HTTP\Response))
#12 /var/www/html/3rdparty/sabre/event/lib/EventEmitterTrait.php(105): call_user_func_array(Array, Array)
#13 /var/www/html/3rdparty/sabre/dav/lib/DAV/Server.php(479): Sabre\Event\EventEmitter->emit('method:PUT', Array)
#14 /var/www/html/3rdparty/sabre/dav/lib/DAV/Server.php(254): Sabre\DAV\Server->invokeMethod(Object(Sabre\HTTP\Request), Object(Sabre\HTTP\Response))
#15 /var/www/html/apps/dav/lib/Server.php(317): Sabre\DAV\Server->exec()
#16 /var/www/html/apps/dav/appinfo/v2/remote.php(35): OCA\DAV\Server->exec()
#17 /var/www/html/remote.php(163): require_once('/var/www/html/a...')
#18 {main}

---

BEGIN:VCARD
VERSION:3.0
PRODID:-//Sabre//Sabre VObject 4.1.6//EN
UID:41e602ab-83cc-46fc-89c2-57dc39243901
REV;VALUE=DATE-AND-OR-TIME:2019-09-04T14:01:20Z
FN:Photo
ADR;TYPE=HOME:;;;;;;
EMAIL;TYPE=HOME:
TEL;TYPE="HOME,VOICE":
CLOUD;TYPE=HOME:
BDAY;VALUE=DATE:20190830
END:VCARD

[kesselb]

server/apps/dav/lib/CalDAV/BirthdayService.php

Lines 236 to 242 in befe38e

	} else {
	$originalYear = (int)$dateParts['year'];
	if ($originalYear < 1970) {
	$birthday = '1970-' . $dateParts['month'] . '-' . $dateParts['date'];
	}
	}

• The data has a year
• There is no X-APPLE-OMIT-YEAR
• And the year is bigger than > 1970

$birthday = $originalYear . '-' . $dateParts['month'] . '-' . $dateParts['date']; as else block should do the trick but just guessing from the code ;) The problem is actually the reuse of $birthday and not the missing else block.