Merged
Conversation
Member
|
Conflicting files |
Signed-off-by: jld3103 <jld3103yt@gmail.com>
9efa1ef to
299fea3
Compare
Member
Author
|
Fixed |
nickvergessen
approved these changes
Dec 21, 2023
Member
nickvergessen
left a comment
There was a problem hiding this comment.
So at least bools only allow int with enum 0 and 1 now, so better than before.
But shouldn't it be listed as bool?
Member
Author
|
The problem is that query parameters are always interpreted as true unless the value is 0. So we need to map them as integers :/ |
Member
|
Added tests in #59 |
Member
But not when you POST a JSON body, but it will work in both cases anyway, so okay |
1 task
Member
Author
|
Yes with a json post body boolean works fine, but not with the query parameters as we use them here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For query parameters we have to convert booleans into integers as they are only accepted that way. This sets the
enumfield on the returned integer schema to indicate that these are the only possible values.Can be tested in the server.