Fix push notifications for multibyte notifications#575
Merged
nickvergessen merged 1 commit intomasterfrom Feb 26, 2020
Merged
Conversation
Member
Author
|
/backport to stable18 |
Member
Author
|
/backport to stable17 |
Member
Author
|
/backport to stable16 |
json_encode is messing with multibyte characters a lot, replacing them with something along "\u1234" instead of the assumed 2-times overhead. The data length in our encryption is a hard limit, but we don't want to make non-utf8 subjects unnecessary short. So this function tries to cut it off first. If that is not enough it always cuts off 5 characters in multibyte-safe fashion until the json_encode-d string is shorter then the given limit. Signed-off-by: Joas Schilling <coding@schilljs.com>
b256db2 to
95a82ce
Compare
Member
Author
|
Merging as per #563 (comment) |
|
backport to stable18 in #576 |
|
backport to stable17 in #577 |
|
The backport to stable16 failed. Please do this backport manually. |
Member
Author
|
backport to stable16 in #586 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
json_encode is messing with multibyte characters a lot,
replacing them with something along "\u1234" instead of the assumed 2-times overhead.
The data length in our encryption is a hard limit, but we don't want to
make non-utf8 subjects unnecessary short. So this function tries to cut
it off first.
If that is not enough it always cuts off 5 characters in multibyte-safe
fashion until the json_encode-d string is shorter then the given limit.
Fix #563