Merged
Conversation
rullzer
approved these changes
Mar 4, 2020
Member
rullzer
left a comment
There was a problem hiding this comment.
Didn't test. But the code look good. And I assume you verified the workings with the push proxy code
Member
Author
|
Yeah, and you can too. Just register a normal android/iOS app and then change the push token hash in the database to an invalid one (replace one char) |
rullzer
approved these changes
Mar 4, 2020
Member
rullzer
left a comment
There was a problem hiding this comment.
quick smoke tests sees to do the trick :D
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
1df1cf8 to
4d2924a
Compare
Member
Author
|
/backport to stable18 |
|
backport to stable18 in #583 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.