Deprecation warnings when using Mail app with PHP 8.5

[DerDreschner]

Steps to reproduce

1. Run the mail app with PHP 8.5
2. Run unit tests

Expected behavior

The unit tests should run without any deprecation warnings as they might (and probably will) appear on production use as well.

Actual behavior

The following deprecation warnings appear regarding Horde libraries:

1. PHP Deprecated:  ord(): Providing an empty string is deprecated in /home/runner/actions-runner/_work/mail/mail/nextcloud/apps/mail/vendor/bytestream/horde-mail/lib/Horde/Mail/Rfc822.php on line 80

3. PHP Deprecated:  trim(): Passing null to parameter #1 ($string) of type string is deprecated in /var/www/html/apps-extra/mail/vendor/bytestream/horde-mime/lib/Horde/Mime/Headers.php on line 139

4. PHP Deprecated:  ArrayIterator::__construct(): Using an object as a backing array for ArrayIterator is deprecated, as it allows violating class constraints and invariants in /home/runner/actions-runner/_work/mail/mail/nextcloud/apps/mail/vendor/bytestream/horde-mime/lib/Horde/Mime/Headers.php on line 506
 
5. PHP Deprecated:  Return type of Horde_Smtp_Filter_Data::filter($in, $out, &$consumed, $closing) should either be compatible with php_user_filter::filter($in, $out, &$consumed, bool $closing): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /home/runner/actions-runner/_work/mail/mail/nextcloud/apps/mail/vendor/nextcloud/horde-smtp/lib/Horde/Smtp/Filter/Data.php on line 36

6. PHP Deprecated:  Return type of Horde_Smtp_Filter_Body::filter($in, $out, &$consumed, $closing) should either be compatible with php_user_filter::filter($in, $out, &$consumed, bool $closing): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /home/runner/actions-runner/_work/mail/mail/nextcloud/apps/mail/vendor/nextcloud/horde-smtp/lib/Horde/Smtp/Filter/Body.php on line 48
 
7. PHP Deprecated:  Return type of Horde_Smtp_Filter_Body::onCreate() should either be compatible with php_user_filter::onCreate(): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /home/runner/actions-runner/_work/mail/mail/nextcloud/apps/mail/vendor/nextcloud/horde-smtp/lib/Horde/Smtp/Filter/Body.php on line 38
 
8. PHP Deprecated:  Creation of dynamic property Horde\ManageSieve::$_capability is deprecated in /home/runner/actions-runner/_work/mail/mail/nextcloud/apps/mail/vendor/nextcloud/horde-managesieve/lib/Horde/ManageSieve.php on line 867

9. PHP Deprecated:  Using null as an array offset is deprecated, use an empty string instead in /var/www/html/apps-extra/mail/vendor/bytestream/horde-mime/lib/Horde/Mime/Part.php on line 1205

The following deprecation warning appears regarding code in the glenscott/url-normalizer library (glenscott/url-normalizer#32):

PHP Deprecated: Automatic conversion of false to array is deprecated in /var/www/html/apps-extra/mail/vendor/glenscott/url-normalizer/src/URL/Normalizer.php on line 376

The following deprecation warnings appear regarding code in the unit tests itself:

1 PHP Deprecated:  Creation of dynamic property OCA\Mail\Tests\Unit\ContextChat\SubmitContentJobTest::$time is deprecated in /var/www/html/apps-extra/mail/tests/Unit/BackgroundJob/ContextChat/SubmitContentJobTest.php on line 70

2. PHP Deprecated:  Creation of dynamic property OCA\Mail\Tests\Unit\ContextChat\SubmitContentJobTest::$imapClientFactory is deprecated in /var/www/html/apps-extra/mail/tests/Unit/BackgroundJob/ContextChat/SubmitContentJobTest.php on line 75

3. PHP Deprecated:  Creation of dynamic property OCA\Mail\Tests\Unit\ContextChat\SubmitContentJobTest::$logger is deprecated in /var/www/html/apps-extra/mail/tests/Unit/BackgroundJob/ContextChat/SubmitContentJobTest.php on line 78

4. PHP Deprecated:  Creation of dynamic property OCA\Mail\Tests\Unit\ContextChat\SubmitContentJobTest::$mailboxMapper is deprecated in /var/www/html/apps-extra/mail/tests/Unit/BackgroundJob/ContextChat/SubmitContentJobTest.php on line 79

5. PHP Deprecated:  Creation of dynamic property OCA\Mail\Tests\Unit\ContextChat\SubmitContentJobTest::$submitContentJob is deprecated in /var/www/html/apps-extra/mail/tests/Unit/BackgroundJob/ContextChat/SubmitContentJobTest.php on line 81
 
7. PHP Deprecated:  Creation of dynamic property OCA\Mail\Tests\Unit\Command\CreateAccountTest::$classificationSettingsService is deprecated in /var/www/html/apps-extra/mail/tests/Unit/Command/CreateAccountTest.php on line 50 
 
8. PHP Deprecated:  Creation of dynamic property OCA\Mail\Tests\Unit\ContextChat\ContextChatProviderTest::$jobList is deprecated in /var/www/html/apps-extra/mail/tests/Unit/ContextChat/ContextChatProviderTest.php on line 71

9. PHP Deprecated:  Method ReflectionProperty::setAccessible() is deprecated since 8.5, as it has no effect since PHP 8.1 in /var/www/html/apps-extra/mail/tests/Unit/Controller/MessagesControllerTest.php on line 521

10. PHP Deprecated:  Method ReflectionProperty::setAccessible() is deprecated since 8.5, as it has no effect since PHP 8.1 in /var/www/html/apps-extra/mail/tests/Unit/Controller/MessagesControllerTest.php on line 525

The following deprecation warning appears regarding code in the server repository:

PHP Deprecated:  Constant DateTimeInterface::RFC7231 is deprecated since 8.5, as this format ignores the associated timezone and always uses GMT in /var/www/html/lib/public/AppFramework/Http/Response.php on line 101

[ChristophWurst]

Creation of dynamic property

I think Rector should be able to find and fix these: https://getrector.com/rule-detail/complete-dynamic-properties-rector

[DerDreschner]

I think Rector should be able to find and fix these: https://getrector.com/rule-detail/complete-dynamic-properties-rector

Interestingly, it doesn't. Even when changing the withPhpSet value from php74: true to php85: true (which would change a lot of code otherwise). PhpStorm doesn't complain as well when changing the language level to PHP 8.5.