[WP#57654]switch encryption for oauth secret#694
Merged
individual-it merged 4 commits intorelease/2.7from Sep 6, 2024
Merged
Conversation
8aa270c to
64675d9
Compare
64675d9 to
b9231fc
Compare
Signed-off-by: Sagar <sagargurung1001@gmail.com>
b9231fc to
71c53dd
Compare
Collaborator
individual-it
left a comment
There was a problem hiding this comment.
there is more logic in createNcOauthClient so need to create unit tests for it
Signed-off-by: Sagar <sagargurung1001@gmail.com>
…sions Signed-off-by: Sagar <sagargurung1001@gmail.com>
individual-it
requested changes
Sep 6, 2024
Signed-off-by: Sagar <sagargurung1001@gmail.com>
individual-it
approved these changes
Sep 6, 2024
PHP Code CoverageCoverage after merging changeEncryptionForOauthForNC into release/2.7 will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Contributor
Author
|
API test is failing because of the flaky test https://github.com/nextcloud/integration_openproject/actions/runs/10729539649. |
nabim777
pushed a commit
that referenced
this pull request
Sep 9, 2024
Signed-off-by: nabim777 <nabinalemagar019@gmail.com>
SagarGi
added a commit
that referenced
this pull request
Sep 10, 2024
8 tasks
SagarGi
added a commit
that referenced
this pull request
Sep 10, 2024
* Drop support for nc 26 (#689) * Adjust or remove code specific to NC-26 Signed-off-by: Sagar <sagargurung1001@gmail.com> * Adjust or remove things realted to stable 26 Signed-off-by: Sagar <sagargurung1001@gmail.com> * fix CI failure Signed-off-by: Sagar <sagargurung1001@gmail.com> * update changelog Signed-off-by: Sagar <sagargurung1001@gmail.com> --------- Signed-off-by: Sagar <sagargurung1001@gmail.com> * Remove version comparision for secret encryption (#695) * Remove version comparision for secret encryption Signed-off-by: Sagar <sagargurung1001@gmail.com> * stlye fix Signed-off-by: Sagar <sagargurung1001@gmail.com> --------- Signed-off-by: Sagar <sagargurung1001@gmail.com> * [WP#56328]Fix error message when upload is restricted by file access control in `Nextcloud` (#688) (#696) * Fix the misleading error message when upload is restricted by file access control app * Added php unit test * update change log --------- Signed-off-by: Sagar <sagargurung1001@gmail.com> Signed-off-by: nabim777 <nabinalemagar019@gmail.com> Co-authored-by: Sagar Gurung <46086950+SagarGi@users.noreply.github.com> * [WP#57654]switch encryption for oauth secret (#694) * ci: Reduce testing matrix Signed-off-by: Joas Schilling <coding@schilljs.com> * CI: Run phpunit test one times more on error (#687) * retry on the phpunit error for ci Signed-off-by: nabim777 <nabinalemagar019@gmail.com> * use pipeline for retry Signed-off-by: nabim777 <nabinalemagar019@gmail.com> --------- Signed-off-by: nabim777 <nabinalemagar019@gmail.com> --------- Signed-off-by: Sagar <sagargurung1001@gmail.com> Signed-off-by: nabim777 <nabinalemagar019@gmail.com> Signed-off-by: Joas Schilling <coding@schilljs.com> Co-authored-by: Nalem7 <61624650+nabim777@users.noreply.github.com> Co-authored-by: Joas Schilling <coding@schilljs.com> Co-authored-by: Artur Neumann <artur@jankaritech.com>
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In OAuth, now the client secret are hashed for greater security which is done in this PR nextcloud/server#47635. Previously we just used to encrypt it.
This PR:
client_secretwhen fetching the client info for the existing user.Related Issue or Workpackage
Screenshots (if appropriate):
Types of changes
Checklist:
CHANGELOG.mdfile