only set spec.replicas in Nextcloud Deployment if .Values.hpa.enabled is set to false#596
Conversation
|
Some kind of test would be nice, the change makes sense but I can not validate it. |
|
I pinged the original person who opened the Issue that this is a fix for, but in the meantime, I do see that all our normal tests passed, so at least without hpa, it's working fine :) But wait, does hpa or multi-replicas actually work right now to begin with? 🤔 To test, I'd have to first see if I can get it working with 2 pods to begin with. I'll take some backups and try at some point today, and based on that, will try to create a ci test for this that triggers on tag of hpa. |
|
Oh, I also found a Kubernetes sanctioned HPA walkthrough here: It doesn't show including a |
|
I think we need a summary job, otherwise this is not going to work when the tests are skipped because there were no changes. |
95c92ae to
2e85081
Compare
|
Rebased and updated description since #598 was merged. Will wait for tests and then we can merge this one :) |
provokateurin
left a comment
There was a problem hiding this comment.
I didn't want to drag out the other PR even further, but I think the test should set hpa.minPods to 2 to ensure it works with multiple pods. I'd assume in the testing only 1 pod gets created which doesn't test the feature well.
Sounds good! I'll push up a commit to test this and if everything passes, we can squash it all into one commit like we did the last PR and be on our way :) |
… is set to false update hpa ci test to use a minimum of 2 pods Signed-off-by: jessebot <jessebot@linux.com>
f528d24 to
9e28608
Compare
Description of the change
spec.replicasin Nextcloud Deployment only ifhpa.enabledin values.yaml is set tofalse.hpa.minPods=2Benefits
This should unbreak the environments that use
hpa.enabledin their values.yaml that also use Argo CD?Possible drawbacks
None that I can think of after #598 was merged! Open to discussion on this one as always :)
Applicable issues
Checklist
Chart.yamlaccording to semver.