Set default for nextcloud.containerPort in values.yaml and update YAML templates to use it everywhere

[jessebot]

Pull Request

Description of the change

Reworked this PR to include other changes from two other PRs to move along these changes faster in bulk.

• Sets default port for nextcloud.containerPort to be 80 in values.yaml.
• Changes the service targetPort for the nextcloud service to be the nextcloud.containerPort.
• Changes all http ports in the deployment template to use nextcloud.containerPort instead (includes probes)

Benefits

allows users to set a custom container port like 9000 and have it be referenced in the service.

Possible drawbacks

unsure, open to suggestion

Applicable issues

• fixes Feature: create service.targetPort parameter or default to nextcloud.containerPort for targetPort in service template #384

Additional information

Checklist

• DCO has been signed off on the commit.
• Chart version bumped in Chart.yaml according to semver.
• (optional) Variables are documented in the README.md

[jessebot]

relates to the following issues:

• Fix(nginx-config): Listen port based on nextcloud.containerPort #278
• Allow probe checks and Service to use containerPort if specified #316

@provokateurin, I noticed you said in #278 (comment) that we should use a default value. Did you mean for nextcloud.containerPort? I can set nextcloud.containerPort in values.yaml. Right now it's commented out here and set to 8080, should it be uncommented and set to 8080 or 80:

helm/charts/nextcloud/values.yaml

Line 88 in cd67e29

# containerPort: 8080

Happy to do the work to get all three PRs moved forward :) Also happy to add any docs you think might be handy

[jessebot]

Actually, I could forgo this PR entirely, as it looks like #316 already updates the service.yaml. Will close this if we can merge the other one.

[jessebot]

Have fixed up this PR because the other PRs that do something similar seem to have gone stale