README updates: Add replicaCount; fix image.flavor, nextcloud.podSecurityContext descriptions#337
Merged
provokateurin merged 5 commits intonextcloud:masterfrom Jan 25, 2023
jessebot:update_readme_options
Merged
README updates: Add replicaCount; fix image.flavor, nextcloud.podSecurityContext descriptions#337provokateurin merged 5 commits intonextcloud:masterfrom jessebot:update_readme_options
replicaCount; fix image.flavor, nextcloud.podSecurityContext descriptions#337provokateurin merged 5 commits intonextcloud:masterfrom
jessebot:update_readme_options
Conversation
these are for different webserver backends. You must use fpm if you're deploying nginx as your webserver instead of apache. Signed-off-by: Jesse Hitch <jessebot@linux.com>
Signed-off-by: Jesse Hitch <jessebot@linux.com>
3 tasks
replicaCount; fix image.flavor, nextcloud.podSecurityContext descriptionsreplicaCount; fix image.flavor, nextcloud.podSecurityContext descriptions
provokateurin
requested changes
Jan 25, 2023
Member
|
Please fix DCO and conflicts. |
…ADME Signed-off-by: Jesse Hitch <jessebot@linux.com>
Signed-off-by: Jesse Hitch <jessebot@linux.com>
Signed-off-by: JesseBot <jessebot@linux.com>
Collaborator
Author
|
If anyone is curious on future markdown table formatting, in vim I use this plugin: vim-table-mode. Then you can just use the command |
provokateurin
approved these changes
Jan 25, 2023
Member
|
Awesome! ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description of the change
This is just updates to the README to include a little bit more info on:
image.flavor(updates table desc, and adds small section below)nextcloud.podSecurityContext(updates table desc)replicaCount(adds param to table)Benefits
Easier cross reference between the values.yaml and README.md to save time on getting started :)
Possible drawbacks
I don't really see any drawbacks to updating the readme.
Applicable issues
Additional information
This is a change only to the README and does not add additional features, so the Chart.yaml doesn't need a version update.
Checklist
Chart.yamlaccording to semver.