Use securityContext for deployment and cronjob#117
Use securityContext for deployment and cronjob#117nlaille wants to merge 3 commits intonextcloud:masterfrom
Conversation
| {{- if .Values.nextcloud.securityContext }} | ||
| {{- with .Values.nextcloud.securityContext }} |
There was a problem hiding this comment.
I would call that nextcloud.podSecurityContext and also add a container securityContext as nextcloud.securityContext.
|
What would be needed to merge this PR? As mentioned in #252 this does prevent deploying the Cron Job in certain scenarios (e.g. when Longhorn is used as the storage layer, see https://longhorn.io/kb/troubleshooting-volume-take-long-time-to-mount/). |
|
@kodemaniak the DCO needs to be signed off by @nlaille |
|
If @nlaille does not sign off the DCO, what are the alternatives? Would you accept an equivalent merge request by someone else? |
Other people can try and submit the same PR, and it looks like it was started in #269, but it needs updating. If it's not done in a day or two, I'll submit another PR, and link back to these two. |
|
Done in #269 |
Pull Request
Description of the change
Do a separation of securityContext for deployment and cronjob.
Benefits
Possibility to set
fsGroupandfsGroupChangePolicyon deployment.With the current setup,
fsGroupandfsGroupChangePolicycannot be set because cronjob and deployment uses the same securityContext and cronjob securityContext doesn't havefsGroupfield.Possible drawbacks
This PR should backward compatible.
Applicable issues
Additional information
Checklist
Chart.yamlaccording to semver.