docs(dev): remove deprecated createEventSource#10479
Merged
Conversation
5 tasks
4a32962 to
4c3b046
Compare
2 tasks
ChristophWurst
approved these changes
May 26, 2023
ab2f9c6 to
834d04f
Compare
Member
ChristophWurst
left a comment
There was a problem hiding this comment.
Could we have a dedicated page for event source and how it's used in an app? 🙏
Contributor
Author
I think we should review the current implementation first, as the code is ancient. To inject IRequest into OC_EventSource was actually a side project for nextcloud/server#38445. |
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
834d04f to
5ea4697
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖼️ Screenshots