Conversation
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
Codecov Report
@@ Coverage Diff @@
## master #593 +/- ##
=======================================
Coverage 75.46% 75.46%
=======================================
Files 52 52
Lines 1969 1969
=======================================
Hits 1486 1486
Misses 483 483 |
Member
Author
|
I'll make a quick revision as per @jancborchardt's comment This will solve issue #250 |
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
juliusknorr
reviewed
Aug 23, 2018
js/controller/ListController.js
Outdated
| $scope.updatingBoard = null; | ||
|
|
||
| var filterData = function () { | ||
| var filterData = function () { |
Member
There was a problem hiding this comment.
We don't need additional whitespace 😉
juliusknorr
reviewed
Aug 23, 2018
templates/part.boardlist.php
Outdated
| </tr> | ||
| </thead> | ||
| <tbody> | ||
| <tbody> |
juliusknorr
requested changes
Aug 23, 2018
Member
juliusknorr
left a comment
There was a problem hiding this comment.
Minor comments, but all in all looks good. 👍
css/style.scss
Outdated
| * General styles | ||
| */ | ||
|
|
||
| .center-text { |
Member
There was a problem hiding this comment.
This doesn't seem to be used anywhere.
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
Member
Author
|
@juliushaertl comments addressed! should be good to merge now :) |
juliusknorr
approved these changes
Aug 23, 2018
Member
|
Merged 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ryan Fletcher ryan.fletcher@codepassion.ca
Summary
Added empty content messages to board listings.
TODO
Checklist