Conversation
0625b37 to
5880952
Compare
Signed-off-by: Julius Härtl <jus@bitgrid.net> fix: Provide relevant app state for widgets Signed-off-by: Julius Härtl <jus@bitgrid.net> fix: Adapt interactive widget Signed-off-by: Julius Härtl <jus@bitgrid.net> chore: fixup Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
5880952 to
db7fa3c
Compare
7 tasks
Member
Author
|
@nextcloud/designers For feedback on the screen recording :) |
Member
jancborchardt
left a comment
There was a problem hiding this comment.
Wow that looks really nice!! :) All in there.
One thing I am not sure about is the height change:
- Currently it seems a bit janky when you modify or filter, the height just jumps around
- What could be better is a set height like 50vh which does not change but is scrollable. Drawback being that it also takes more when not needed.
What do you think @juliushaertl? I would also be fine with the current solution but generally it's nice if the UI feels "solid".
Signed-off-by: Julius Härtl <jus@bitgrid.net>
db7fa3c to
28f0490
Compare
Member
Author
|
Yes, adjusted, much better that way. I think this is fine as the board certainly has a couple of cards most of the time. |
Signed-off-by: Julius Härtl <jus@bitgrid.net>
jancborchardt
approved these changes
Mar 6, 2024
Member
jancborchardt
left a comment
There was a problem hiding this comment.
Good from my side then!
luka-nextcloud
approved these changes
Mar 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementing an interactive widget for deck boards
Kapture.2024-02-29.at.17.59.35.webm