Skip to content

feat: Move to contenteditable for inline title editing#5282

Merged
juliusknorr merged 1 commit intomainfrom
feat/inline-edit-new
Nov 14, 2023
Merged

feat: Move to contenteditable for inline title editing#5282
juliusknorr merged 1 commit intomainfrom
feat/inline-edit-new

Conversation

@juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Nov 13, 2023 •
edited
Loading

@luka-nextcloud
Copy link
Contributor

luka-nextcloud commented Nov 13, 2023

@juliushaertl I guess this PR is not done yet, right? As far as I can see, clicking the title is enabling title editing and opening card detail at the same time.

@juliusknorr
Copy link
Member Author

juliusknorr commented Nov 13, 2023

Will check maybe I messed something up by splitting the commits out

Base automatically changed from bugfix/multiple to main November 13, 2023 14:16
@juliusknorr
feat: Move to contenteditable for inline title editing
a6b561a 
fix #2563
fix #4522

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Copy link
Member Author

juliusknorr commented Nov 13, 2023 •
edited
Loading

Fixed, apparently I did miss that as when using the sidebar it is not that disturbing compared to the modal.

@juliusknorr juliusknorr mentioned this pull request Nov 13, 2023
Merged
13 tasks
@juliusknorr juliusknorr merged commit cdba29d into main Nov 14, 2023
@juliusknorr juliusknorr deleted the feat/inline-edit-new branch November 14, 2023 07:51
This was referenced May 9, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@luka-nextcloud luka-nextcloud luka-nextcloud approved these changes

@mejo- mejo- Awaiting requested review from mejo-

Assignees

No one assigned

Labels

3. to review enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

autosave card title Don't open input field when clicking on title in Deck

2 participants

@juliusknorr @luka-nextcloud