Improve stack drag and drop behavior#4074
Conversation
|
hey @juliushaertl any chance for a review or anything i can do to speed this along? :) i would like to avoid piling up merge conflicts. |
Signed-off-by: Simon Hötten <s+git@hoetten.org>
Signed-off-by: Simon Hötten <s+git@hoetten.org>
Signed-off-by: Simon Hötten <s+git@hoetten.org>
e78b201 to
cd5753f
Compare
|
Thanks a lot for your contribution and sorry for taking so long. I'm fine to merge this without e2e tests as for the dragging part that might indeed be tricky. If you are curious still, some basic tests for the editing and cancel editing behaviour would be highly appreciated. Since we just added cypress recently and do not have a large coverage yet, every addition is welcome there. You can start the cypress gui locally running against your local development instance with the following command. The only requirement should be to have deck installed and enabled and a admin user with the password |
|
Let me merge this to move on, as mentioned, if you still would be up for some test case a follow up PR would be highly appreciated :) |
|
@juliushaertl Here we go #4206 |
Summary
This allows stacks only to be dragged by the title, minimizing accidental drag'n'drops. Also the title can not be edited accidentally while dragging the stack. (see #2669 (comment))
As a bonus, stack title edits can now aborted via or clicking away (same as card titles).
If you want me to add some e2e tests, maybe you can provide me with some pointers? To be honest, i'm not very keen on writing drag'n'drop tests, because they often end up flacky, in my experience..
Checklist