Do not open the dialog automatically upon card creation, only upon click#2435
Merged
juliusknorr merged 5 commits intomasterfrom Oct 13, 2020
Merged
Do not open the dialog automatically upon card creation, only upon click#2435juliusknorr merged 5 commits intomasterfrom
juliusknorr merged 5 commits intomasterfrom
Conversation
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Member
Author
|
/backport to stable1.1 |
Member
marcoambrosini
left a comment
There was a problem hiding this comment.
@juliushaertl I wouldn't open the sidebar either upon card creation, what do you think?
Member
|
Actually, @juliushaertl, the sidebar should probably never overlap the content, just like in talk |
Member
Author
It doesn't, the scroll container is reduced to the remaining width. That is a bit special for deck of course, but there is no way around horizontal scrolling here. |
Member
|
So this is the problem I'm thinking of here:
|
Member
Author
|
Ok, there it might help already if we scroll the cards into view after inserting them with #2230 |
marcoambrosini
approved these changes
Oct 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix modal design issues as proposed in #2423