Use unified search events to apply on board filtering#2255
Merged
juliusknorr merged 1 commit intomasterfrom Oct 2, 2020
Merged
Use unified search events to apply on board filtering#2255juliusknorr merged 1 commit intomasterfrom
juliusknorr merged 1 commit intomasterfrom
Conversation
jakobroehrl
approved these changes
Sep 2, 2020
Contributor
jakobroehrl
left a comment
There was a problem hiding this comment.
This is working, but I dont know how useful it is.
If the user does any click while showing the search results the search results are gone
Member
Author
|
Yeah, we could just not reset the search query in deck when the unified search is closed but there would be no indicator or way to reset it then afterwards of course. @skjnldsv Were there any discussions about that already UX wise? Issue in summary:
|
This was referenced Sep 16, 2020
Merged
Signed-off-by: Julius Härtl <[email protected]>
59b5f27 to
012e5b8
Compare
skjnldsv
approved these changes
Oct 2, 2020
Member
sorry I missed this comment. Yeah, you fixed it with the reset/close event differences 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires nextcloud/server#22526 on the server