feat: add logical_operators as a required rule

[susnux]

• resolves Proposal use logical_operators #48

[come-nc]

I’m not sure this is important enough to enable risky changes in our coding standard. Application should be able to rely on the cs-fixer not breaking anything.

[ChristophWurst]

I’m not sure this is important enough to enable risky changes in our coding standard. Application should be able to rely on the cs-fixer not breaking anything.

This is a good point I hadn't realized in #50. Generally enabling risky rules by default sounds like a bad idea.
Could you keep it off by default and still enable the logical operators when someone opts in?

[nickvergessen]

Could you keep it off by default and still enable the logical operators when someone opts in?

We can, the sad thing is that if the config can not access the passed --allow-risky to only define the rule when the user opted-in.
So my vote would be to not include the rule for now and run it manually once in server to clear it. I've never seen it outside of server, as it's very uncommon anyway.

[nickvergessen]

On that note: https://github.com/symfony/symfony/blob/7.4/.php-cs-fixer.dist.php#L50

I guess it's okay, as the only risky thing is if we add a new risky rule at some point. Because going forward it would prevent anyone from using and/or in first place, so there is no risk from that rule anymore.

[ChristophWurst]

So my vote would be to not include the rule for now and run it manually once in server to clear it. I've never seen it outside of server, as it's very uncommon anyway.

This makes most sense

[susnux]

So how to continue here?

[nickvergessen]

I'll try to have a look that we can add our own validator with psalm similar to the OCP since checker:
https://github.com/vimeo/psalm/blob/2b0ff73c8bed091af231a0a80ac109126c92083a/src/Psalm/Internal/Analyzer/Statements/Expression/BinaryOpAnalyzer.php#L61-L62

[nickvergessen]

• ci(psalm): Add a checker against logical operators server#56284

[susnux]

thank you @nickvergessen