feat: Allow to enforce ellipsis instead of three dots#28
feat: Allow to enforce ellipsis instead of three dots#28
Conversation
Our translation and design guidelines say to use ellipsis instead of three dots, yet some code is using three dots instead of the ellipsis character. This adds a custom fixer and rule to allow auto-fixing those strings. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
7b39377 to
0ceffd5
Compare
|
Good idea, especially because it's also enforced for apps then. Do we still run https://github.com/nextcloud/server/blob/master/build/triple-dot-checker.php? |
|
~30 files in server.
That's a bit weird, but okay. |
ChristophWurst
left a comment
There was a problem hiding this comment.
I'm on the fence with this.
As Daniel shows, this might influence strings that are not user visible, and this is more of a semantic check/fix. I think the cs fixer should only fix syntax formatting.
Should this be a Psalm rule like build/psalm/OcpSinceChecker.php?
|
Or (when it's only about user facing strings) in the translation checker? |
The idea was to also check for apps.
If that makes more sense for you, then sure. I can look into that when I have some more time. |
Yeah the above and some future checks should be done for all apps as well |
Our translation and design guidelines say to use ellipsis instead of three dots, yet some code is using three dots instead of the ellipsis character. This adds a custom fixer and rule to allow auto-fixing those strings.
I did not default enable it, because it is a risky rule that might change behavior (e.g. string comparison).
Feel free to dismiss if you feel like this should not be enforced.