enforce forceAll

[ArtificialOwl]

Should fix #576

[ArtificialOwl]

/backport to stable21

[ArtificialOwl]

/backport to stable20

[ArtificialOwl]

/backport to stable19

[luckyhandler]

I only checked the code and didn't test it.

[solracsf]

Not working here. Only reverting #566 fixes those issues, with the downside of #566 (comment)

[Art4]

Please excuse me if I'm wrong but this PR doesn't do anything. (I neglect a possible speed advantage)
It just moves the $forceAll === true to the first position in the if-condition.

[juliusknorr]

@daita I pushed another commit in order to also pass the forceAll parameter to the method that fetches the members list, which fixes the issue on my test setup.

Please excuse me if I'm wrong but this PR doesn't do anything. (I neglect a possible speed advantage)
It just moves the $forceAll === true to the first position in the if-condition.

It is not only a speed advantage but due to the OR operation if the first one matches the others will never get evaluated, so the $circle->getHigherViewer()->isLevel() which attempted to call on null then would never be executed if forceAll is used. Unfortunately it was only the first half of the fix 😉

Anyways testing of the two patches together is highly appreciated.

[Art4]

@juliushaertl Thank you for the explanation.

[armouredking]

Modifications do not fix for me, see #576 (I can't reopen bug).

[ArtificialOwl]

/backport to stable20

[ArtificialOwl]

/backport to stable19