Skip to content

Verify test failure #16329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
PhilLab wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Verify test failure #16329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dd6a782
Do not merge - just testing test failures
PhilLab Jan 21, 2026
80dd90b
Do not merge - just testing test failure
PhilLab Jan 24, 2026
a539e6d
Do not merge - just testing test failure of GalleryFragmentIT
PhilLab Jan 24, 2026
0857693
DO NOT merge - testing unit test failure
PhilLab Feb 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions app/src/androidTest/java/com/nextcloud/client/FileDisplayActivityIT.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,6 +261,8 @@ class FileDisplayActivityIT : AbstractOnServerIT() {
onView(allOf(withText(loadingText), isDisplayed()))
.check(doesNotExist())

assertTrue("Do not merge - just testing test failures", false)
Copy link
Contributor Author

@PhilLab PhilLab Jan 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the second failure I provoke

Copy link
Contributor Author

@PhilLab PhilLab Jan 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also wasn't catched - https://drone.nextcloud.com/nextcloud/android/27788 ran through and no other test job ran the test either.

For reference, this is the overview of checks for this commit: https://github.com/nextcloud/android/pull/16329/checks?sha=0becd054d1b3eefad3327626ea3d5b79cf397eba.

And the screenshot
image


// Test that there is no timing issue when hiding the dialog directly after.
// This timing issue was reproducible when testing RemoveFilesDialogFragment#removeFiles
// as well as sporadically "in the wild".
Expand Down
3 changes: 3 additions & 0 deletions app/src/androidTest/java/com/owncloud/android/ui/fragment/GalleryFragmentIT.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ import com.owncloud.android.utils.ScreenshotTest
import org.junit.After
import org.junit.Assert.assertEquals
import org.junit.Assert.assertNotNull
import org.junit.Assert.assertTrue
import org.junit.Before
import org.junit.Test
import java.util.Random
Expand Down Expand Up @@ -120,6 +121,8 @@ class GalleryFragmentIT : AbstractIT() {
onView(withId(R.id.list_root))
.perform(RecyclerViewActions.scrollToLastPosition<GalleryRowHolder>())
.perform(RecyclerViewActions.scrollToPosition<GalleryRowHolder>(0))

assertTrue("Do not merge - just testing test failures", false)
Copy link
Contributor Author

@PhilLab PhilLab Jan 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the third failure I provoke

Copy link
Contributor Author

@PhilLab PhilLab Jan 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drone also passed: https://drone.nextcloud.com/nextcloud/android/27789.

Check overview: https://github.com/nextcloud/android/pull/16329/checks?sha=dbd4897d8a21b0bd17d993c030074091f6e4e3c4

And screenshot of the PR overview:
image

}

// Test selection of all entries
Expand Down
2 changes: 2 additions & 0 deletions app/src/androidTest/java/com/owncloud/android/ui/preview/PreviewImageActivityIT.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,8 @@ class PreviewImageActivityIT : AbstractOnServerIT() {
}
onView(isRoot()).check(matches(isDisplayed()))

assertTrue("Do not merge - just testing test failures", false)
Copy link
Contributor Author

@PhilLab PhilLab Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is where I provoke the failure

Copy link
Contributor Author

@PhilLab PhilLab Jan 24, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was not catched - https://drone.nextcloud.com/nextcloud/android/27697 ran through. And no other test job failed, either.

For reference, this is the overview of GitHub's checks for this commit, but somehow it does not show the drone action... Very confusing... https://github.com/nextcloud/android/pull/16329/checks?sha=71ac686c47076f8d24c71eae1bdcadf06214eeba

But as this view confusingly doesn't list the Drone job, I'll leave this screenshot as well, at the state of this commit. Drone job is shown green:
image


for (testFile in expectedFileOrder) {
veryImageThenDelete(testFile)
assertTrue(
Expand Down
1 change: 1 addition & 0 deletions app/src/test/java/com/owncloud/android/utils/OwnCloudSessionTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ public void setName_assertCorrectNameUpdated() {

@Test
public void getName_assertCorrectNamedRetrieved() {
assertEquals("NOCOMMIT", "");
assertEquals("OwnCloudSession name not correct", SESSION_NAME, ownCloudSession.getSessionName());
}

Expand Down
Loading