Bugfix Fix NPE FileDataStorageManager

[alperozturk96]

• Tests written, or not not needed

What this PR Does?

• Get FileDataStorageManager only from DI, remove creation from SessionMix. Both are same no need to have both of it.
• Make account non nullable

How to Test?

1. Have 2 account in the app, switch accounts and check files for each account.
2. Delete app and make fresh install
3. Have 2 account in app and switch accounts and check FileDataStorageManager and DefaultAccount those variable must contain selected account from ManageAccount Dialog

[tobiasKaminsky]

Hm. DI uses CurrentAccountProvider.
SessionMixin uses UserAccountManager, which extends from CurrentAccountProvider.

So I guess it is okay to use them.

But the real fix would be to find out why it is null in first place.
Else app might then bail out on next NPE inside SessionMixin.

Can you see a bit more of stracktrace to guess when this might happen?

[alperozturk96]

Hm. DI uses CurrentAccountProvider. SessionMixin uses UserAccountManager, which extends from CurrentAccountProvider.

So I guess it is okay to use them.

But the real fix would be to find out why it is null in first place. Else app might then bail out on next NPE inside SessionMixin.

Can you see a bit more of stracktrace to guess when this might happen?

fun setAccount(account: Account?) {
        val validAccount = account != null && accountManager.setCurrentOwnCloudAccount(account.name)
        if (validAccount) {
            currentAccount = account
        } else {
            swapToDefaultAccount()
        }

        currentAccount?.let {
            val storageManager = FileDataStorageManager(getUser().get(), contentResolver)
            this.storageManager = storageManager
        }
    }

This function set the storage manager inside SessionMixin passed parameter can be null so currentAccount become a null.

So can we say both are the same?

Not valid anymore

[alperozturk96]

/rebase

[ZetaTom]

On my test device the app crashes on the first launch after a fresh install.

Logcat

FATAL EXCEPTION: main
Process: com.nextcloud.client, PID: 4224
java.lang.RuntimeException: Unable to create application com.owncloud.android.MainApp: java.lang.ArrayIndexOutOfBoundsException: length=0; index=0
        at android.app.ActivityThread.handleBindApplication(ActivityThread.java:6717)
        at android.app.ActivityThread.access$1300(ActivityThread.java:237)
        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1913)
        at android.os.Handler.dispatchMessage(Handler.java:106)
        at android.os.Looper.loop(Looper.java:223)
        at android.app.ActivityThread.main(ActivityThread.java:7656)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:592)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:947)
Caused by: java.lang.ArrayIndexOutOfBoundsException: length=0; index=0
        at com.nextcloud.client.account.UserAccountManagerImpl.getCurrentAccount(UserAccountManagerImpl.java:157)
        at com.nextcloud.client.account.UserAccountManagerImpl.getUser(UserAccountManagerImpl.java:225) 
        at com.owncloud.android.utils.theme.MaterialSchemesProviderImpl.getMaterialSchemesForCurrentUser(MaterialSchemesProviderImpl.kt:48)
        at com.nextcloud.client.di.ThemeModule$Companion.provideMaterialSchemes(ThemeModule.kt:42)
        at com.nextcloud.client.di.ThemeModule_Companion_ProvideMaterialSchemesFactory.provideMaterialSchemes(ThemeModule_Companion_ProvideMaterialSchemesFactory.java:47)
        at com.nextcloud.client.di.ThemeModule_Companion_ProvideMaterialSchemesFactory.get(ThemeModule_Companion_ProvideMaterialSchemesFactory.java:37)
        at com.nextcloud.client.di.ThemeModule_Companion_ProvideMaterialSchemesFactory.get(ThemeModule_Companion_ProvideMaterialSchemesFactory.java:13)
        at com.owncloud.android.utils.theme.ViewThemeUtils_Factory.get(ViewThemeUtils_Factory.java:39)  
        at com.owncloud.android.utils.theme.ViewThemeUtils_Factory.get(ViewThemeUtils_Factory.java:12)  
        at com.owncloud.android.MainApp.onCreate(MainApp.java:301)
        at android.app.Instrumentation.callApplicationOnCreate(Instrumentation.java:1192)
        at android.app.ActivityThread.handleBindApplication(ActivityThread.java:6712)
        at android.app.ActivityThread.access$1300(ActivityThread.java:237) 
        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1913) 
        at android.os.Handler.dispatchMessage(Handler.java:106) 
        at android.os.Looper.loop(Looper.java:223) 
        at android.app.ActivityThread.main(ActivityThread.java:7656) 
        at java.lang.reflect.Method.invoke(Native Method) 
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:592) 
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:947)

[alperozturk96]

UserAccountManagerImpl

AnonymousAccount logic added for fresh install.

Not valid anymore

[tobiasKaminsky]

test-Unit test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/13074-Unit-test-15-03

@alperozturk96 this seems to be related to your changes.

[tobiasKaminsky]

Have you tested multiple accounts?

[alperozturk96]

Have you tested multiple accounts?

Yes. App is working as expected during my tests. I will fix test and update PR.

[alperozturk96]

test-Unit test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/13074-Unit-test-15-03

@alperozturk96 this seems to be related to your changes.

This test is not valid anymore. Account can't be null so I removed the test.

[github-actions]

Codacy

Lint

Type	master	PR
Warnings	69	69
Errors	3	3

SpotBugs

Category	Base	New
Bad practice	64	64
Correctness	68	68
Dodgy code	344	344
Experimental	1	1
Internationalization	7	7
Multithreaded correctness	6	6
Performance	57	57
Security	18	18
Total	565	565

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/13074.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[alperozturk96]

/backport to stable-3.29